Skip to content

feat(falcon): Set name and source on request span when streaming - #6562

Merged
alexander-alderman-webb merged 17 commits into
masterfrom
webb/falcon/txn-name
Jun 16, 2026
Merged

feat(falcon): Set name and source on request span when streaming#6562
alexander-alderman-webb merged 17 commits into
masterfrom
webb/falcon/txn-name

docstring v2

2943c3d
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Jun 16, 2026 in 0s

2 issues

Low

First `capture_items("event")` call is immediately overwritten and produces a dangling monkeypatch chain - `tests/integrations/falcon/test_falcon.py:130`

The line items = capture_items("event") is immediately shadowed by items = capture_items("event", "span") on the next line, so the first list is never used. Each capture_items(...) call uses monkeypatch.setattr to wrap capture_envelope, so the first call installs a wrapper that silently populates a discarded list, creating an unnecessary wrapper in the call chain. The first line should be removed.

Dead `capture_items("event")` assignment immediately overwritten in falcon test - `tests/integrations/falcon/test_falcon.py:126-127`

In test_transaction_style, the span_streaming branch calls items = capture_items("event") and then immediately overwrites items with capture_items("event", "span") on the next line. The first call's return list is never used, and because capture_items monkeypatches test_client.transport.capture_envelope on each invocation, the redundant first call installs an extra nested transport patch whose collected list is discarded. The first line should be removed.

4 skills analyzed
Skill Findings Duration Cost
security-review 0 2.9s $0.01
code-review 1 3m 14s $0.54
find-bugs 1 3m 50s $0.72
skill-scanner 0 6.2s $0.01

⏱ 7m 13s · 770.8k in / 42.0k out · $1.28