Conversation
|
vitaliset is a new contributor to projects/qemu. The PR must be approved by known contributors before it can be merged. The past contributors are: a1xndr |
|
Output of |
|
Output of |
| ################################################################################ | ||
|
|
||
| cd $SRC/qemu/build-oss-fuzz | ||
| make -j"$(nproc)" check-unit |
There was a problem hiding this comment.
Not sure if we want to have this initial version while we figure out how to make make check work. WDYT @DavidKorczynski, @AdamKorcz? If so, should I add a comment here?
There was a problem hiding this comment.
I would say go for the the tests that work and thus avoid make check. Looking at the above logs it looks like there are ASAN issues with qemu and make check.
Our options are: build a version without ASAN or avoid these tests. I say at this point in time we should avoid the tests and thus avoid make check.
I'm happy to go for subset of tests that work well if the problems of the failing tests seem bigger than adjusting the set up in a minor manner. I think that should work for our usecases atm. This one seem to require adjustments a bit on the larger side to make it work.
DavidKorczynski
left a comment
There was a problem hiding this comment.
LGTM, but I agree on your comment to add a todo for the larger tests. Or at least a note that this tests a subset because there are larger issues with make check itself.
Adds
run_tests.shto the qemu project.run_tests.shis used as part of Chronos with cached builds: https://github.com/google/oss-fuzz/tree/master/infra/experimental/chronos#check-testsOutput of ./infra/experimental/chronos/check_tests.sh qemu c++: