Skip to content

qemu: add run_tests.sh #13618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidKorczynski merged 2 commits into from
Jul 14, 2025
Merged

qemu: add run_tests.sh #13618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0620ce2
unit tests qemu
vitaliset Jul 13, 2025
d23ee93
Update run_tests.sh
vitaliset Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/qemu/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ RUN git clone --depth 1 https://gitlab.gnome.org/GNOME/glib.git --branch=$glib_t

RUN git clone --depth 1 https://git.qemu.org/git/qemu.git qemu
WORKDIR qemu
COPY build.sh $SRC/
COPY run_tests.sh build.sh $SRC/
3 changes: 2 additions & 1 deletion projects/qemu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/bin/sh -e # Copyright 2020 Google Inc.
#!/bin/sh -e
# Copyright 2020 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down
20 changes: 20 additions & 0 deletions projects/qemu/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#!/bin/bash -eu
# Copyright 2025 Google LLC.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
################################################################################

cd $SRC/qemu/build-oss-fuzz
# TODO: These tests are a subset of `make check` because there are larger
# comparability issues with running them all.
make -j"$(nproc)" check-unit
Copy link
Copy Markdown
Contributor Author

@vitaliset vitaliset Jul 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to have this initial version while we figure out how to make make check work. WDYT @DavidKorczynski, @AdamKorcz? If so, should I add a comment here?

Copy link
Copy Markdown
Collaborator

@DavidKorczynski DavidKorczynski Jul 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say go for the the tests that work and thus avoid make check. Looking at the above logs it looks like there are ASAN issues with qemu and make check.

Our options are: build a version without ASAN or avoid these tests. I say at this point in time we should avoid the tests and thus avoid make check.

I'm happy to go for subset of tests that work well if the problems of the failing tests seem bigger than adjusting the set up in a minor manner. I think that should work for our usecases atm. This one seem to require adjustments a bit on the larger side to make it work.