Open
Conversation
|
ligurio is either the primary contact or is in the CCs list of projects/lua. |
26 tasks
6bca742 to
648bcfa
Compare
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Mar 27, 2026
Sometimes one need to compile a luzer module with a non-system Lua library and headers, for which the LUA_LIBRARIES and LUA_INCLUDE_DIR CMake options are used. The patch adds variables for the rockspec to set these options via environment variables: LUA_LIBRARIES and LUA_INCLUDE_DIR. Needed for google/oss-fuzz#14610
648bcfa to
b14c354
Compare
ligurio
added a commit
to ligurio/lunapark
that referenced
this pull request
Mar 27, 2026
The patch itnroduces a CMake option ENABLE_LIBFUZZER_STATIC_LINKAGE that enables static linkage wituh libFuzzer. By default linkage is disabled. Needed for google/oss-fuzz#14610
5b5ddaa to
ff72ffc
Compare
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Mar 27, 2026
Sometimes one need to compile a luzer module with a non-system Lua library and headers, for which the LUA_LIBRARIES and LUA_INCLUDE_DIR CMake options are used. The patch adds variables for the rockspec to set these options via environment variables: LUA_LIBRARIES and LUA_INCLUDE_DIR. Needed for google/oss-fuzz#14610
48eff90 to
5aca8b2
Compare
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 6, 2026
Sometimes one need to build a luzer module using rockspec with a non-system Lua library and headers, for which the CMake options LUA_LIBRARIES and LUA_INCLUDE_DIR are used. The patch adds variables for the rockspec to set these options via environment variables: CMAKE_LUA_LIBRARIES, CMAKE_LUA_INCLUDE_DIR, ENABLE_LUAJIT and LUAJIT_FRIENDLY_MODE. luarocks install --lua-version 5.1 --verbose --tree=lua_modules \ luzer-scm-1.rockspec ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 6, 2026
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers, for which the CMake options LUA_LIBRARIES and LUA_INCLUDE_DIR are used. The patch adds variables for the rockspec to set these options via environment variables: CMAKE_LUA_LIBRARIES, CMAKE_LUA_INCLUDE_DIR, ENABLE_LUAJIT and LUAJIT_FRIENDLY_MODE. luarocks install --lua-version 5.1 --verbose --tree=lua_modules \ luzer-scm-1.rockspec ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 6, 2026
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers, for which the CMake options LUA_LIBRARIES and LUA_INCLUDE_DIR are used. The patch adds variables for the rockspec to set these options via environment variables: CMAKE_LUA_LIBRARIES, CMAKE_LUA_INCLUDE_DIR, ENABLE_LUAJIT and LUAJIT_FRIENDLY_MODE. luarocks install --tree=lua_modules luzer-scm-1.rockspec \ ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 7, 2026
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers or set other CMake options before building. The patch adds variables for the rockspec to set the following CMake options via environment variables: CMAKE_LUA_LIBRARIES, CMAKE_LUA_INCLUDE_DIR, ENABLE_LUAJIT and LUAJIT_FRIENDLY_MODE: luarocks install --tree=lua_modules luzer-scm-1.rockspec \ ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON The patch also renames a CMake variables used for setting custom Lua library and Lua include directory: LUA_LIBRARIES to CMAKE_LUA_LIBRARIES and LUA_INCLUDE_DIR to CMAKE_LUA_INCLUDE_DIR. This is needed because with empty environment variables LUA_LIBRARIES and LUA_INCLUDE_DIR passed to luarocks breaks CMake module for finding Lua package: CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is at least version "5.1") Call Stack (most recent call first): /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.28/Modules/FindLua.cmake:236 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:49 (find_package) Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 7, 2026
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers or set other CMake options before building. The patch adds variables for the rockspec to set the following CMake options via environment variables: CMAKE_LUA_LIBRARIES, CMAKE_LUA_INCLUDE_DIR, ENABLE_LUAJIT and LUAJIT_FRIENDLY_MODE: luarocks install --tree=lua_modules luzer-scm-1.rockspec \ ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON The patch also renames a CMake variables used for setting custom Lua library and Lua include directory: LUA_LIBRARIES to CMAKE_LUA_LIBRARIES and LUA_INCLUDE_DIR to CMAKE_LUA_INCLUDE_DIR. This is needed because with empty environment variables LUA_LIBRARIES and LUA_INCLUDE_DIR passed to luarocks breaks CMake module for finding Lua package: CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is at least version "5.1") Call Stack (most recent call first): /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.28/Modules/FindLua.cmake:236 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:49 (find_package) Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 7, 2026
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers or set other CMake options before building. The patch adds variables for the rockspec to set the following CMake options via environment variables: CMAKE_LUA_LIBRARIES, CMAKE_LUA_INCLUDE_DIR, ENABLE_LUAJIT, LUAJIT_FRIENDLY_MODE and OSS_FUZZ: luarocks install --tree=lua_modules luzer-scm-1.rockspec \ ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON The patch also renames a CMake variables used for setting custom Lua library and Lua include directory: LUA_LIBRARIES to CMAKE_LUA_LIBRARIES and LUA_INCLUDE_DIR to CMAKE_LUA_INCLUDE_DIR. This is needed because with empty environment variables LUA_LIBRARIES and LUA_INCLUDE_DIR passed to luarocks breaks CMake module for finding Lua package: CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is at least version "5.1") Call Stack (most recent call first): /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.28/Modules/FindLua.cmake:236 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:49 (find_package) Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 7, 2026
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers or set other CMake options before building. The patch adds variables for the rockspec to set the following CMake options via environment variables: ENABLE_LUAJIT, LUAJIT_FRIENDLY_MODE and OSS_FUZZ: luarocks install --tree=lua_modules luzer-scm-1.rockspec \ ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON The patch also renames CMake variables used for setting a custom Lua library and Lua include directory: LUA_LIBRARIES to CMAKE_LUA_LIBRARIES and LUA_INCLUDE_DIR to CMAKE_LUA_INCLUDE_DIR. This is needed because with empty environment variables LUA_LIBRARIES and LUA_INCLUDE_DIR passed to luarocks breaks CMake module for finding Lua package: CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is at least version "5.1") Call Stack (most recent call first): /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.28/Modules/FindLua.cmake:236 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:49 (find_package) After renaming these options can be specified for luarocks. Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 7, 2026
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers or set other CMake options before building. The patch adds variables for the rockspec to set the following CMake options via environment variables: ENABLE_LUAJIT, LUAJIT_FRIENDLY_MODE and OSS_FUZZ: luarocks install --tree=lua_modules luzer-scm-1.rockspec \ ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON The patch also renames CMake variables used for setting a custom Lua library and Lua include directory: LUA_LIBRARIES to CMAKE_LUA_LIBRARIES and LUA_INCLUDE_DIR to CMAKE_LUA_INCLUDE_DIR. This is needed because with empty environment variables LUA_LIBRARIES and LUA_INCLUDE_DIR passed to luarocks breaks CMake module for finding Lua package: CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is at least version "5.1") Call Stack (most recent call first): /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.28/Modules/FindLua.cmake:236 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:49 (find_package) After renaming these options can be specified for luarocks. Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 7, 2026
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers or set other CMake options before building. The patch adds variables for the rockspec to set the following CMake options via environment variables: ENABLE_LUAJIT, LUAJIT_FRIENDLY_MODE and OSS_FUZZ: luarocks install --tree=lua_modules luzer-scm-1.rockspec \ ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON The patch also renames CMake variables used for setting a custom Lua library and Lua include directory: LUA_LIBRARIES to CMAKE_LUA_LIBRARIES and LUA_INCLUDE_DIR to CMAKE_LUA_INCLUDE_DIR. This is needed because with empty environment variables LUA_LIBRARIES and LUA_INCLUDE_DIR passed to luarocks breaks CMake module for finding Lua package: CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is at least version "5.1") Call Stack (most recent call first): /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.28/Modules/FindLua.cmake:236 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:49 (find_package) After renaming these options can be specified for luarocks. The patch also sorts variables in alphabetical order. Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 7, 2026
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers or set other CMake options before building. The patch adds variables for the rockspec to set the following CMake options via environment variables: ENABLE_LUAJIT, LUAJIT_FRIENDLY_MODE and OSS_FUZZ: luarocks install --tree=lua_modules luzer-scm-1.rockspec \ ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON The patch also renames CMake variables used for setting a custom Lua library and Lua include directory: LUA_LIBRARIES to CMAKE_LUA_LIBRARIES and LUA_INCLUDE_DIR to CMAKE_LUA_INCLUDE_DIR. This is needed because with empty environment variables LUA_LIBRARIES and LUA_INCLUDE_DIR passed to luarocks breaks CMake module for finding Lua package: CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is at least version "5.1") Call Stack (most recent call first): /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.28/Modules/FindLua.cmake:236 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:49 (find_package) After renaming these options can be specified for luarocks. The patch also sorts variables in alphabetical order. Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/lunapark
that referenced
this pull request
Apr 7, 2026
The patch itnroduces a CMake option ENABLE_LIBFUZZER_STATIC_LINKAGE that enables static linkage wituh libFuzzer. By default linkage is disabled. Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 7, 2026
The previous patch is not set LUA_INCLUDE_DIR when custom Lua include directory is used. The patch fixes that. Also, rockspec has missed variables CMAKE_LUA_LIBRARIES and CMAKE_LUA_INCLUDE_DIR. The patch adds these variables. Follows up the commit 2a58b8a ("rockspec: propagate CMake options"). Needed for google/oss-fuzz#14610
ligurio
added a commit
to ligurio/lunapark
that referenced
this pull request
Apr 7, 2026
The patch itnroduces a CMake option DISABLE_LIBFUZZER_STATIC_LINKAGE that disables static linkage wituh libFuzzer. By default linkage is enabled. Needed for google/oss-fuzz#14610
5aca8b2 to
73f555c
Compare
73f555c to
0e03ce8
Compare
ligurio
added a commit
to ligurio/luzer
that referenced
this pull request
Apr 7, 2026
The previous patch is not set LUA_INCLUDE_DIR when custom Lua include directory is used. The patch fixes that. Also, rockspec has missed variables CMAKE_LUA_LIBRARIES and CMAKE_LUA_INCLUDE_DIR. The patch adds these variables. Follows up the commit 2a58b8a ("rockspec: propagate CMake options"). Needed for google/oss-fuzz#14610
d24af8f to
c169cce
Compare
ligurio
added a commit
to ligurio/lunapark
that referenced
this pull request
Apr 7, 2026
The patch itnroduces a CMake option DISABLE_LIBFUZZER_STATIC_LINKAGE that disables static linkage wituh libFuzzer. By default linkage is enabled. Needed for google/oss-fuzz#14610
ad3c460 to
e4accfb
Compare
sudo python infra/helper.py build_fuzzers lua sudo python infra/helper.py check_build lua utf8_char_test Related to ligurio/lunapark#180 Related to ligurio/luzer#83
e4accfb to
323e75d
Compare
Contributor
Author
|
@DavidKorczynski ok to merge? |
Contributor
Author
|
@jonathanmetzman ok to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #13929
Depends on ligurio/luzer#74
Depends on ligurio/lunapark#179
Depends on ligurio/luzer#82
Related to ligurio/lunapark#180
Related to ligurio/luzer#83