Merged
Conversation
ligurio
force-pushed
the
ligurio/gh-xxxx-define-dirs-rockspec
branch
from
288a07e to
09a22e4
Compare
ligurio
added a commit
to ligurio/oss-fuzz
that referenced
this pull request
Mar 27, 2026
Will gone after merging ligurio/luzer#82
ligurio
force-pushed
the
ligurio/gh-xxxx-define-dirs-rockspec
branch
from
48c0b51 to
9231e3c
Compare
ligurio
added a commit
to ligurio/oss-fuzz
that referenced
this pull request
Mar 27, 2026
Will gone after merging ligurio/luzer#82
26 tasks
ligurio
force-pushed
the
ligurio/gh-xxxx-define-dirs-rockspec
branch
4 times, most recently
from
c9c1315 to
6c4c5ed
Compare
ligurio
added a commit
to ligurio/oss-fuzz
that referenced
this pull request
Mar 27, 2026
Will gone after merging ligurio/luzer#82
ligurio
added a commit
to ligurio/oss-fuzz
that referenced
this pull request
Mar 27, 2026
Will gone after merging ligurio/luzer#82
ligurio
added a commit
to ligurio/oss-fuzz
that referenced
this pull request
Mar 27, 2026
Will gone after merging ligurio/luzer#82
ligurio
added a commit
to ligurio/oss-fuzz
that referenced
this pull request
Mar 27, 2026
Will gone after merging ligurio/luzer#82
Buristan
approved these changes
Apr 3, 2026
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
LGTM, with a minor nit below.
Sometimes one need to compile a luzer module with a non-system Lua
Typo: s/need/needs/
ligurio
force-pushed
the
ligurio/gh-xxxx-define-dirs-rockspec
branch
from
d4cdf45 to
a752226
Compare
Owner
Author
|
The patch can be tested with patch below: --- a/luzer-scm-1.rockspec
+++ b/luzer-scm-1.rockspec
@@ -2,7 +2,7 @@ package = "luzer"
version = "scm-1"
source = {
url = "git+https://github.com/ligurio/luzer",
- branch = "master",
+ branch = "ligurio/gh-xxxx-define-dirs-rockspec",
}
description = { |
ligurio
changed the title
ligurio
changed the title
ligurio
force-pushed
the
ligurio/gh-xxxx-define-dirs-rockspec
branch
7 times, most recently
from
8111c89 to
7c4e79f
Compare
Sometimes one needs to build a luzer module using rockspec with a non-system Lua library and headers or set other CMake options before building. The patch adds variables for the rockspec to set the following CMake options via environment variables: ENABLE_LUAJIT, LUAJIT_FRIENDLY_MODE and OSS_FUZZ: luarocks install --tree=lua_modules luzer-scm-1.rockspec \ ENABLE_LUAJIT=ON LUAJIT_FRIENDLY_MODE=ON The patch also renames CMake variables used for setting a custom Lua library and Lua include directory: LUA_LIBRARIES to CMAKE_LUA_LIBRARIES and LUA_INCLUDE_DIR to CMAKE_LUA_INCLUDE_DIR. This is needed because with empty environment variables LUA_LIBRARIES and LUA_INCLUDE_DIR passed to luarocks breaks CMake module for finding Lua package: CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Lua (missing: LUA_LIBRARIES LUA_INCLUDE_DIR) (Required is at least version "5.1") Call Stack (most recent call first): /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake-3.28/Modules/FindLua.cmake:236 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:49 (find_package) After renaming these options can be specified for luarocks. The patch also sorts variables in alphabetical order. Needed for google/oss-fuzz#14610
ligurio
force-pushed
the
ligurio/gh-xxxx-define-dirs-rockspec
branch
from
7c4e79f to
6f9c893
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for google/oss-fuzz#14610