fix: allow precise probe coordinates - #1832
Open
loglapa wants to merge 3 commits into
Open
Conversation
Signed commits reportAll 3 commits between |
|
|
loglapa
force-pushed
the
fix-434-coordinate-precision
branch
from
August 25, 2026 17:19
ac52379 to
ccfdffe
Compare
loglapa
marked this pull request as ready for review
August 25, 2026 17:25
loglapa
force-pushed
the
fix-434-coordinate-precision
branch
from
August 25, 2026 18:50
ccfdffe to
3215447
Compare
g3john
requested changes
Aug 26, 2026
Signed-off-by: Vladislav Lapin <51929896+loglapa@users.noreply.github.com>
loglapa
force-pushed
the
fix-434-coordinate-precision
branch
from
August 26, 2026 16:50
3215447 to
be25815
Compare
Author
|
The requested coordinate precision change is addressed in be25815: both latitude and longitude inputs now use an explicit 0.000001 step instead of step="any", with regression coverage for the six-decimal contract. Focused tests, typecheck, and ESLint pass; Bugbot and the available GitHub checks are green. @g3john ready for re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Testing
yarn test src/components/ProbeEditor/ProbeEditor.test.tsx --runInBand(14 tests)yarn typecheckyarn lintgit diff --checkAll project commands were run in Docker.
Fixes #434