Skip to content

fix: allow precise probe coordinates #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loglapa wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: allow precise probe coordinates #1832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c152908
fix: allow precise probe coordinates
loglapa Aug 25, 2026
be25815
fix: use explicit coordinate precision
loglapa Aug 26, 2026
239d0af
Merge branch 'main' into fix-434-coordinate-precision
loglapa Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/components/ProbeEditor/ProbeEditor.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,20 @@ describe('validation', () => {
const errorMessage = await screen.findByText('Longitude must be less than 180');
expect(errorMessage).toBeInTheDocument();
});

it('accepts coordinates with Google Maps precision', async () => {
const { user } = await renderProbeEditor();
const latitudeInput = await screen.findByLabelText('Latitude', { exact: false });
const longitudeInput = await screen.findByLabelText('Longitude', { exact: false });

await user.type(latitudeInput, '34.697135');
await user.type(longitudeInput, '-84.383184');

expect(latitudeInput).toHaveAttribute('step', '0.000001');
expect(longitudeInput).toHaveAttribute('step', '0.000001');
expect(latitudeInput).toBeValid();
expect(longitudeInput).toBeValid();
});
});

it('renders the back button', async () => {
Expand Down
4 changes: 2 additions & 2 deletions src/components/ProbeEditor/ProbeEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export const ProbeEditor = ({
})}
aria-label="Latitude"
placeholder="0.0"
step={0.00001}
step={0.000001}
type="number"
/>
</Field>
Expand All @@ -129,7 +129,7 @@ export const ProbeEditor = ({
valueAsNumber: true,
})}
aria-label="Longitude"
step={0.00001}
step={0.000001}
type="number"
placeholder="0.0"
/>
Expand Down
Loading