fix(dap): respect supports_terminate_request#14826
Merged
the-mikedavis merged 1 commit intohelix-editor:masterfrom Nov 24, 2025
Merged
fix(dap): respect supports_terminate_request#14826the-mikedavis merged 1 commit intohelix-editor:masterfrom
the-mikedavis merged 1 commit intohelix-editor:masterfrom
Conversation
If the DAP server doesn't support terminate request, don't send it. Fixes: helix-editor#14782
the-mikedavis
approved these changes
Nov 24, 2025
a3lem
pushed a commit
to a3lem/helix
that referenced
this pull request
Jan 11, 2026
Eucladia
pushed a commit
to Eucladia/helix
that referenced
this pull request
Jan 20, 2026
fryeb
pushed a commit
to fryeb/helix
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the DAP server doesn't support terminate request, don't send it.
Fixes: #14782