Skip to content

fix(dap): respect supports_terminate_request #14826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
the-mikedavis merged 1 commit into from
Nov 24, 2025
Merged

fix(dap): respect supports_terminate_request #14826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions helix-term/src/commands/dap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,15 +586,23 @@ pub fn dap_terminate(cx: &mut Context) {
cx.editor.set_status("Terminating debug session...");
let debugger = debugger!(cx.editor);

let terminate_arguments = Some(TerminateArguments {
restart: Some(false),
});
if debugger
.caps
.as_ref()
.is_some_and(|c| c.supports_terminate_request.unwrap_or_default())
{
let terminate_arguments = Some(TerminateArguments {
restart: Some(false),
});

let request = debugger.terminate(terminate_arguments);
dap_callback(cx.jobs, request, |editor, _compositor, _response: ()| {
// editor.set_error(format!("Failed to disconnect: {}", e));
editor.debug_adapters.unset_active_client();
});
let request = debugger.terminate(terminate_arguments);
dap_callback(cx.jobs, request, |editor, _compositor, _response: ()| {
// editor.set_error(format!("Failed to disconnect: {}", e));
editor.debug_adapters.unset_active_client();
});
} else {
cx.editor.debug_adapters.unset_active_client();
}
}

pub fn dap_enable_exceptions(cx: &mut Context) {
Expand Down