Update Persian translations (fa, fa_IR) for Django application#897
Conversation
|
Please check this PR. @Andrew-Chen-Wang |
| #, python-format | ||
| msgid "Blacklisted token for %(user)s" | ||
| msgstr "" | ||
| msgstr "توکن لیست سیاه برای %(user)s" |
There was a problem hiding this comment.
Hi is this using Google Translate? Persian should be right to left
There was a problem hiding this comment.
Hi, no, it's a manual translation. Persian is RTL, but PO files handle it correctly.
There was a problem hiding this comment.
do you have a link or proof of this in a demo app? send a picture
| #| msgid "No active account found with the given credentials" | ||
| msgid "No active account found for the given token." | ||
| msgstr "هیچ اکانت فعالی برای اطلاعات داده شده یافت نشد" | ||
| msgstr "هیچ اکانت فعالی برای توکن داده شده یافت نشد." |
There was a problem hiding this comment.
why is there a period at the end?
There was a problem hiding this comment.
why have you marked this as resolved? Periods go at the left, not right, correct?
There was a problem hiding this comment.
Hi, I adjusted the translation for accuracy. In Persian, punctuation follows the text, so the period is correct.
Andrew-Chen-Wang
left a comment
Andrew-Chen-Wang
left a comment
There was a problem hiding this comment.
thx for the PR and thx for clarifying concerns in the comments!
|
You're welcome! Glad I could help, and thanks for reviewing! |
|
Will this PR be merged? If any changes are needed, please let me know so I can make them. @Andrew-Chen-Wang |
2 participants
This pull request updates the Persian translations for the
djangorestframework-simplejwtproject, adding support for both the "fa" and "fa_IR" languages. The translations include various messages related to token handling, authentication, and errors. This update aims to improve the localization for Persian-speaking users using the package.Changes:
.pofiles to reflect the latest translationsThis update ensures better localization support and enhances the user experience for Persian-speaking users.
Please review and merge the changes to improve localization for the project.