fix: use semantic version comparison instead of string comparison#34
Merged
gordonmurray merged 1 commit intoApr 6, 2026
Merged
Conversation
Version checks in the /healthz endpoint used string comparison (e.g. lancedb_version >= "0.5") which is lexicographic, not numeric. This produces incorrect results for certain version numbers: "0.9" >= "0.16" evaluates to True as a string comparison, but 0.9 is less than 0.16 semantically. Replaced with packaging.version.parse() which handles semver correctly. packaging is available as a transitive dependency of pip/setuptools. Fixes lance-format#20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthzused string comparison (lancedb_version >= "0.5") which is lexicographic, not numeric"0.9" >= "0.16"evaluates toTrueas a string, but 0.9 < 0.16 semanticallypackaging.version.parse()which handles semver correctlypackagingis available as a transitive dependency of pip/setuptools, no new dependencies neededChanges
One file changed:
backend/app.pyfrom packaging.version import parse as parse_versioncompatdict withparse_version()callsTest
All currently supported versions produce correct results:
Fixes #20