Skip to content

fix: use semantic version comparison instead of string comparison #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gordonmurray merged 1 commit into from
Apr 6, 2026
Merged

fix: use semantic version comparison instead of string comparison #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import lancedb
import pyarrow as pa
from packaging.version import parse as parse_version
from fastapi import FastAPI, HTTPException, Query
from fastapi.middleware.cors import CORSMiddleware
from fastapi.responses import JSONResponse
Expand Down Expand Up @@ -126,8 +127,8 @@ async def health_check():
# Determine compatibility features based on Lance version
compat = {
"vector_preview": True,
"schema_evolution": lancedb_version >= "0.5",
"lance_v2_format": lancedb_version >= "0.16"
"schema_evolution": parse_version(lancedb_version) >= parse_version("0.5"),
"lance_v2_format": parse_version(lancedb_version) >= parse_version("0.16")
}

# Generate build tag
Expand Down
Loading