GH#28359: avoid substring replacement in workflow caller test by marcusquinn · Pull Request #28364 · marcusquinn/aidevops

marcusquinn · 2026-07-20T20:22:02Z

Summary

Restrict the workflow-expression null conversion to standalone null tokens so actor names and other words containing null remain unchanged.

Files Changed

.agents/scripts/tests/test-reusable-workflow-caller.sh

Runtime Testing

Risk level: Low (agent prompts / infrastructure scripts)
Verification: shellcheck .agents/scripts/tests/test-reusable-workflow-caller.sh; bash .agents/scripts/tests/test-reusable-workflow-caller.sh (26 tests passed)

Resolves #28359

aidevops.sh v3.32.159 plugin for OpenCode v1.18.4 with gpt-5.6-sol spent 1m and 36,121 tokens on this as a headless worker.

marcusquinn · 2026-07-20T20:22:13Z

Completion Summary

What: Restrict the workflow-expression null conversion to standalone null tokens so actor names and other words containing null remain unchanged.
Issue: Review followup: PR #28353 — GH#28316: gate review concurrency after eligibility #28359
Files changed: .agents/scripts/tests/test-reusable-workflow-caller.sh
Testing: shellcheck .agents/scripts/tests/test-reusable-workflow-caller.sh; bash .agents/scripts/tests/test-reusable-workflow-caller.sh (26 tests passed)
Key decisions: Use Python regex word boundaries after deterministic expression substitutions to preserve embedded null substrings.

aidevops.sh v3.32.159 plugin for OpenCode v1.18.4 with gpt-5.6-sol spent 2m and 36,121 tokens on this as a headless worker.

Merged via PR #28364 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

github-actions · 2026-07-20T20:22:50Z

Shell Function Complexity Regression Gate

✅ No regression — no new function(s) >100 lines.

Metric	Base (`3aa92f5`)	Head (`feae3bb`)
Total function(s) >100 lines	0	0

github-actions · 2026-07-20T20:22:56Z

Bash 3.2 Compatibility Regression Gate

✅ No regression — no new bash 3.2-incompatible construct(s).

Metric	Base (`3aa92f5`)	Head (`feae3bb`)
Total bash 3.2-incompatible construct(s)	0	0

github-actions · 2026-07-20T20:23:05Z

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

SonarCloud: 0 bugs, 0 vulnerabilities, 1 code smells

Mon Jul 20 20:23:01 UTC 2026: Code review monitoring started
Mon Jul 20 20:23:01 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 1

📈 Current Quality Metrics

BUGS: 0
CODE SMELLS: 1
VULNERABILITIES: 0

Generated on: Mon Jul 20 20:23:04 UTC 2026

Generated by AI DevOps Framework Code Review Monitoring

gemini-code-assist

Code Review

This pull request updates the evaluation logic in .agents/scripts/tests/test-reusable-workflow-caller.sh to replace the literal string "null" with "None" using a regular expression with word boundaries (\bnull\b) instead of a simple dictionary replacement. The reviewer identified a potential bug where performing this regex substitution after replacing dynamic variables (such as github.actor) could inadvertently alter actor names containing "null" (e.g., changing "null-bot" to "None-bot"). The reviewer suggested executing the regex replacement before the dynamic variable loop to prevent this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

github-actions · 2026-07-20T20:23:11Z

Qlty Smell Regression Gate

✅ No change — smell count unchanged.

Metric	Base (`3aa92f5`)	Head (`feae3bb`)	Delta
Total smells	51	51	+0

codacy-production · 2026-07-20T20:24:40Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

alex-solovyev

Auto-approved by pulse runner @alex-solovyev — author @marcusquinn confirmed collaborator, pre-merge gates passed.

aidevops.sh v3.32.159 automated scan.

github-actions · 2026-07-20T20:25:45Z

Shell Nesting Depth Regression Gate

✅ No regression — no new file(s) with nesting depth >8.

Metric	Base (`3aa92f5`)	Head (`feae3bb`)
Total file(s) with nesting depth >8	0	0

coderabbitai · 2026-07-20T20:25:49Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

🚫 Excluded labels (none allowed) (1)

no-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 93072521-1e51-4797-a1f5-23a693a67fc6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/auto-20260720-211925-gh28359

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-20T20:25:53Z

File Size Regression Gate

✅ No regression — no new non-README Markdown file(s) >500 lines.

Metric	Base (`3aa92f5`)	Head (`feae3bb`)
Total non-README Markdown file(s) >500 lines	0	0

alex-solovyev · 2026-07-21T13:06:27Z

Stuck-merge detector: PR has been merge-eligible but unmerged past the threshold

The pulse merge pass has classified PR #28364 as STUCK_OTHER and it has been sitting unmerged longer than AIDEVOPS_MERGE_STUCK_AGE_MINUTES (currently 240m). The deterministic merge gates are evaluated every cycle (~120s) and this PR has consistently failed them.

Failing checks on PR #28364

(no FAILURE entries in rollup; check rollup manually)

Worker guidance for the next attempt

Read PR GH#28359: avoid substring replacement in workflow caller test #28364 body + the latest check run logs:
```
gh pr checks 28364 --repo marcusquinn/aidevops
```
If the failing checks are environment/Setup-step (Format, Lint, Typecheck all FAIL at the same step), the canonical default branch likely has a broken lockfile or a CI infra change — fix at the base, not on this PR. Look for a sibling outage meta-issue in this repo (filed by the same detector) before forking off here.
If the failures are PR-specific (e.g. a Typecheck error introduced by this PR's code), rebase onto the latest default branch and address the diagnosed errors. Use full-loop-helper.sh start from the linked PR's worktree.
If the linked issue body lacks the worker-ready file paths and verification commands required by t1900, post a comment naming the missing context before dispatching another worker — the next attempt will burn tokens on exploration otherwise.

Why you're seeing this

Every pulse cycle (~120s) the deterministic merge pass re-evaluates open PRs. PRs that pass APPROVED + MERGEABLE but fail required checks have historically been re-evaluated silently every cycle until a human noticed. The stuck-merge detector (t3193) surfaces them after AIDEVOPS_MERGE_STUCK_AGE_MINUTES minutes idle. This comment is posted exactly once per linked issue — repeated stuck cycles will NOT spam the thread. If the PR merges and the issue is reopened later with a fresh stuck PR, the marker will allow a second comment.

_{Posted automatically by pulse-merge-stuck.sh (t3193 / GH#21895). Threshold env: AIDEVOPS_MERGE_STUCK_AGE_MINUTES=240.}

aidevops.sh v3.32.161 automated scan.

marcusquinn · 2026-07-21T15:21:30Z

CLAIM_RELEASED reason=clean runner=marcusquinn ts=2026-07-21T15:21:28Z aidevops_version=3.32.161 opencode_version=1.18.4 exit=0 session_count=1

aidevops.sh v3.32.161 plugin for OpenCode v1.18.4

github-actions · 2026-07-21T15:21:50Z

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

SonarCloud: 0 bugs, 0 vulnerabilities, 1 code smells

Tue Jul 21 15:21:45 UTC 2026: Code review monitoring started
Tue Jul 21 15:21:45 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 1

📈 Current Quality Metrics

BUGS: 0
CODE SMELLS: 1
VULNERABILITIES: 0

Generated on: Tue Jul 21 15:21:48 UTC 2026

Generated by AI DevOps Framework Code Review Monitoring

sonarqubecloud · 2026-07-21T15:24:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vladimirdulov

Auto-approved by pulse runner @vladimirdulov — author @marcusquinn confirmed collaborator, pre-merge gates passed.

aidevops.sh v3.32.145 automated scan.

fix: replace only standalone null tokens

ca4cf89

marcusquinn added the origin:worker Auto-created by pulse labelless backfill (t2112) label Jul 20, 2026

marcusquinn added the status:in-review PR open, awaiting review/merge label Jul 20, 2026

gemini-code-assist Bot reviewed Jul 20, 2026

View reviewed changes

Comment thread .agents/scripts/tests/test-reusable-workflow-caller.sh Outdated

alex-solovyev previously approved these changes Jul 20, 2026

View reviewed changes

marcusquinn mentioned this pull request Jul 20, 2026

[Supervisor:marcusquinn] 5 PRs, 5 assigned, 0 workers at 07:00 UTC #23126

Open

vladimirdulov mentioned this pull request Jul 20, 2026

[Supervisor:vladimirdulov] 5 PRs, 0 assigned, 0 workers at 05:47 UTC #23855

Open

alex-solovyev mentioned this pull request Jul 20, 2026

[Supervisor:alex-solovyev] 5 PRs, 0 assigned, 0 workers at 04:28 UTC #23404

Open

This was referenced Jul 20, 2026

Review followup: PR #28353 — GH#28316: gate review concurrency after eligibility #28359

Closed

merge-stuck outage: 3 PRs sharing failure fingerprint in marcusquinn/aidevops #28387

Closed

This was referenced Jul 21, 2026

merge-stuck outage: 3 PRs sharing failure fingerprint in marcusquinn/aidevops #28391

Closed

merge-stuck outage: 3 PRs sharing failure fingerprint in marcusquinn/aidevops #28404

Closed

fix: normalize null before workflow substitutions

feae3bb

marcusquinn dismissed alex-solovyev’s stale review via feae3bb July 21, 2026 15:21

marcusquinn added status:available Task is available for claiming and removed status:in-review PR open, awaiting review/merge labels Jul 21, 2026

coderabbitai Bot approved these changes Jul 21, 2026

View reviewed changes

vladimirdulov approved these changes Jul 21, 2026

View reviewed changes

alex-solovyev merged commit 0455e76 into main Jul 21, 2026
82 of 84 checks passed

alex-solovyev deleted the feature/auto-20260720-211925-gh28359 branch July 21, 2026 15:31

vladimirdulov added the review-feedback-scanned Merged PR already scanned for quality feedback label Jul 21, 2026

Conversation

marcusquinn commented Jul 20, 2026

Summary

Files Changed

Runtime Testing

Uh oh!

marcusquinn commented Jul 20, 2026 • edited by alex-solovyev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Completion Summary

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Shell Function Complexity Regression Gate

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bash 3.2 Compatibility Regression Gate

Uh oh!

github-actions Bot commented Jul 20, 2026

🔍 Code Quality Report

📈 Current Quality Metrics

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qlty Smell Regression Gate

Uh oh!

codacy-production Bot commented Jul 20, 2026

Up to standards ✅

Uh oh!

alex-solovyev left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Shell Nesting Depth Regression Gate

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

File Size Regression Gate

Uh oh!

alex-solovyev commented Jul 21, 2026

Stuck-merge detector: PR has been merge-eligible but unmerged past the threshold

Failing checks on PR #28364

Worker guidance for the next attempt

Why you're seeing this

Uh oh!

marcusquinn commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

🔍 Code Quality Report

📈 Current Quality Metrics

Uh oh!

sonarqubecloud Bot commented Jul 21, 2026

Quality Gate passed

Uh oh!

vladimirdulov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marcusquinn commented Jul 20, 2026 •

edited by alex-solovyev

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading