Skip to content

GH#28359: avoid substring replacement in workflow caller test #28364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-solovyev merged 2 commits into from
Jul 21, 2026
Merged

GH#28359: avoid substring replacement in workflow caller test #28364

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca4cf89
fix: replace only standalone null tokens
marcusquinn Jul 20, 2026
feae3bb
fix: normalize null before workflow substitutions
marcusquinn Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/scripts/tests/test-reusable-workflow-caller.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,12 +382,12 @@ def evaluate(event_name, actor, is_pr, reply_id):
"github.event.issue.pull_request": repr(is_pr),
"github.event_name": repr(event_name),
"github.actor": repr(actor),
"null": "None",
"&&": "and",
"||": "or",
}
for source, target in replacements.items():
candidate = candidate.replace(source, target)
candidate = re.sub(r"\bnull\b", "None", candidate)
Comment thread
marcusquinn marked this conversation as resolved.
Outdated
if re.search(r"[^A-Za-z0-9_\s\[\]'\"().=-]", candidate):
raise ValueError(f"unsupported eligibility token: {candidate}")
return bool(eval(candidate, {"__builtins__": {}}, {}))
Expand Down
Loading