Reclassify nodeModulesAllowJsImportAssignment JS emit diffs as accepted baselines#3872
Draft
Copilot wants to merge 2 commits into
Draft
Reclassify nodeModulesAllowJsImportAssignment JS emit diffs as accepted baselines#3872Copilot wants to merge 2 commits into
nodeModulesAllowJsImportAssignment JS emit diffs as accepted baselines#3872Copilot wants to merge 2 commits into
Conversation
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix JS declaration emit for require-style imports
Reclassify May 15, 2026
nodeModulesAllowJsImportAssignment JS emit diffs as accepted baselines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS declaration emit for
import = require(...)in JS now includesexport import, which changes surface shape versus prior Strada output. This PR treats that output as the expected direction and reclassifies the affected baselines from triaged to accepted.Baseline classification update
testdata/submoduleTriaged.txt:conformance/nodeModulesAllowJsImportAssignment(module=node16).js.diffconformance/nodeModulesAllowJsImportAssignment(module=node18).js.diffconformance/nodeModulesAllowJsImportAssignment(module=node20).js.diffconformance/nodeModulesAllowJsImportAssignment(module=nodenext).js.difftestdata/submoduleAccepted.txt.Reference baseline relocation
.difffiles from:testdata/baselines/reference/submoduleTriaged/conformance/testdata/baselines/reference/submoduleAccepted/conformance/Representative diff behavior