Skip to content

Reclassify nodeModulesAllowJsImportAssignment JS emit diffs as accepted baselines#3872

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/move-to-submodule-accepted
Draft

Reclassify nodeModulesAllowJsImportAssignment JS emit diffs as accepted baselines#3872
Copilot wants to merge 2 commits into
mainfrom
copilot/move-to-submodule-accepted

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

JS declaration emit for import = require(...) in JS now includes export import, which changes surface shape versus prior Strada output. This PR treats that output as the expected direction and reclassifies the affected baselines from triaged to accepted.

  • Baseline classification update

    • Removed these entries from testdata/submoduleTriaged.txt:
      • conformance/nodeModulesAllowJsImportAssignment(module=node16).js.diff
      • conformance/nodeModulesAllowJsImportAssignment(module=node18).js.diff
      • conformance/nodeModulesAllowJsImportAssignment(module=node20).js.diff
      • conformance/nodeModulesAllowJsImportAssignment(module=nodenext).js.diff
    • Added the same entries to testdata/submoduleAccepted.txt.
  • Reference baseline relocation

    • Moved corresponding .diff files from:
      • testdata/baselines/reference/submoduleTriaged/conformance/
    • To:
      • testdata/baselines/reference/submoduleAccepted/conformance/
  • Representative diff behavior

    // previous baseline expectation
    import fs2 = require("fs")
    
    // current/accepted expectation
    export import fs2 = require("fs")

Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix JS declaration emit for require-style imports Reclassify nodeModulesAllowJsImportAssignment JS emit diffs as accepted baselines May 15, 2026
Copilot AI requested a review from RyanCavanaugh May 15, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baselines: JS declaration emit adds export import modifier for require-style import assignments

2 participants