Skip to content

Reclassify nodeModulesAllowJsImportAssignment JS emit diffs as accepted baselines #3872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Reclassify nodeModulesAllowJsImportAssignment JS emit diffs as accepted baselines #3872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f28de7
Initial plan
Copilot May 15, 2026
be3c634
Move import-assignment diffs to submoduleAccepted
Copilot May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...JsImportAssignment(module=node16).js.diff → ...JsImportAssignment(module=node16).js.diff
View file
Open in desktop
File renamed without changes.
0 ...JsImportAssignment(module=node18).js.diff → ...JsImportAssignment(module=node18).js.diff
View file
Open in desktop
File renamed without changes.
0 ...JsImportAssignment(module=node20).js.diff → ...JsImportAssignment(module=node20).js.diff
View file
Open in desktop
File renamed without changes.
0 ...ImportAssignment(module=nodenext).js.diff → ...ImportAssignment(module=nodenext).js.diff
View file
Open in desktop
File renamed without changes.
4 changes: 4 additions & 0 deletions testdata/submoduleAccepted.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,6 +939,10 @@ conformance/nodeModulesAllowJsImportMeta(module=node16).js.diff
conformance/nodeModulesAllowJsImportMeta(module=node18).js.diff
conformance/nodeModulesAllowJsImportMeta(module=node20).js.diff
conformance/nodeModulesAllowJsImportMeta(module=nodenext).js.diff
conformance/nodeModulesAllowJsImportAssignment(module=node16).js.diff
conformance/nodeModulesAllowJsImportAssignment(module=node18).js.diff
conformance/nodeModulesAllowJsImportAssignment(module=node20).js.diff
conformance/nodeModulesAllowJsImportAssignment(module=nodenext).js.diff
conformance/nodeModulesAllowJsTopLevelAwait(module=node16).js.diff
conformance/nodeModulesAllowJsTopLevelAwait(module=node18).js.diff
conformance/nodeModulesAllowJsTopLevelAwait(module=node20).js.diff
Expand Down
7 changes: 0 additions & 7 deletions testdata/submoduleTriaged.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,6 @@ compiler/multiLinePropertyAccessAndArrowFunctionIndent1.errors.txt.diff
compiler/parseErrorIncorrectReturnToken.errors.txt.diff
conformance/parserStatementIsNotAMemberVariableDeclaration1(alwaysstrict=true).errors.txt.diff

# JS declaration emit adds `export import` modifier for require-style import assignments
## https://github.com/microsoft/typescript-go/issues/3542
conformance/nodeModulesAllowJsImportAssignment(module=node16).js.diff
conformance/nodeModulesAllowJsImportAssignment(module=node18).js.diff
conformance/nodeModulesAllowJsImportAssignment(module=node20).js.diff
conformance/nodeModulesAllowJsImportAssignment(module=nodenext).js.diff

# CJS `module.exports = {}` now emits `export = _default` with inlined object type instead of named exports
## https://github.com/microsoft/typescript-go/issues/3543
compiler/jsDeclarationEmitExportAssignedArray.js.diff
Expand Down