Conversation
…v-refactor # Conflicts: # mingle-app/rn/android/app/src/main/java/com/minglelabs/mingle/rn/NativeSTTModule.kt # mingle-app/rn/ios/mingle/NativeSTTModule.swift
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: befed0add9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (options.sttModel != null) { | ||
| config.put("stt_model", options.sttModel) | ||
| } | ||
| .put("soniox_manual_finalize_silence_ms", options.sonioxManualFinalizeSilenceMs) |
There was a problem hiding this comment.
.put call in Android STT config builder
After making stt_model optional, this block leaves a chained .put(...) call unattached to any receiver (if is now a statement), which causes Kotlin compilation to fail in Android builds. Any RN Android build that compiles NativeSTTModule.kt will break here, so the config construction needs to be rewritten as separate config.put(...) statements (or a single uninterrupted chain).
Useful? React with 👍 / 👎.
…v-refactor # Conflicts: # mingle-app/rn/android/app/src/main/java/com/minglelabs/mingle/rn/NativeSTTModule.kt # mingle-app/rn/ios/mingle/NativeSTTModule.swift # mingle-ios/MingleIOS/Core/Network/STTWebSocketClient.swift # mingle-ios/MingleIOS/ViewModels/AppViewModel.swift
…v-refactor # Conflicts: # mingle-app/src/components/LivePhoneDemo/use-realtime-stt.ts
…v-refactor # Conflicts: # mingle-app/rn/android/app/src/main/java/com/minglelabs/mingle/rn/NativeSTTModule.kt # mingle-app/src/components/LivePhoneDemo/use-realtime-stt.ts # mingle-stt/stt-server.ts
1 participant
Summary
STT_DEFAULT_MODELon the STT servermainchanges and preserve the newer native STT config fields while resolving merge conflictsSafety
sonioxSTT_DEFAULT_MODELis unset, blank, or unsupported, the server falls back tosonioxNotes
Testing
pnpm --dir mingle-app/rn exec tsc --noEmitpnpm --dir mingle-app test:unit