-
Notifications
You must be signed in to change notification settings - Fork 0
codex/stt-provider-env-refactor #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NamHyeongKeol
wants to merge
7
commits into
main
Choose a base branch
from
codex/stt-provider-env-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4af37ae
refactor: make STT provider configurable by env
NamHyeongKeol 8a0384d
Merge remote-tracking branch 'origin/main' into codex/stt-provider-en…
NamHyeongKeol ab3c17f
Merge remote-tracking branch 'origin/main' into codex/stt-provider-en…
NamHyeongKeol befed0a
Merge remote-tracking branch 'origin/main' into codex/stt-provider-en…
NamHyeongKeol bf58421
Merge remote-tracking branch 'origin/main' into codex/stt-provider-en…
NamHyeongKeol 7aeef46
Merge remote-tracking branch 'origin/main' into codex/stt-provider-en…
NamHyeongKeol fe5489b
Merge remote-tracking branch 'origin/main' into codex/stt-provider-en…
NamHyeongKeol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| export const SUPPORTED_STT_MODELS = [ | ||
| 'gladia', | ||
| 'gladia-stt', | ||
| 'deepgram', | ||
| 'deepgram-multi', | ||
| 'fireworks', | ||
| 'soniox', | ||
| ] as const; | ||
|
|
||
| export type SttModel = (typeof SUPPORTED_STT_MODELS)[number]; | ||
|
|
||
| export function isSttModel(value: string): value is SttModel { | ||
| return SUPPORTED_STT_MODELS.includes(value as SttModel); | ||
| } | ||
|
|
||
| export function resolveSttModel(input: unknown, fallback: SttModel): SttModel { | ||
| if (typeof input !== 'string') return fallback; | ||
| const normalized = input.trim(); | ||
| if (!normalized) return fallback; | ||
| return isSttModel(normalized) ? normalized : fallback; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.putcall in Android STT config builderAfter making
stt_modeloptional, this block leaves a chained.put(...)call unattached to any receiver (ifis now a statement), which causes Kotlin compilation to fail in Android builds. Any RN Android build that compilesNativeSTTModule.ktwill break here, so the config construction needs to be rewritten as separateconfig.put(...)statements (or a single uninterrupted chain).Useful? React with 👍 / 👎.