Explicitly unregister hotkeys when resetting hotkeys#1248
Merged
nikitabobko merged 1 commit intonikitabobko:mainfrom Mar 30, 2025
Merged
Explicitly unregister hotkeys when resetting hotkeys#1248nikitabobko merged 1 commit intonikitabobko:mainfrom
nikitabobko merged 1 commit intonikitabobko:mainfrom
Conversation
We cannot always rely on destruction of the HotKey object to trigger unregistration because we might be running inside a hotkey handler that is keeping its HotKey object alive. _fixes nikitabobko#1231
Owner
|
Thanks! I've checked that it fixes the issue. Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot always rely on destruction of the HotKey object to trigger
unregistration because we might be running inside a hotkey handler that
is keeping its HotKey object alive.
_fixes #1231