Skip to content

Explicitly unregister hotkeys when resetting hotkeys #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikitabobko merged 1 commit into from
Mar 30, 2025
Merged

Explicitly unregister hotkeys when resetting hotkeys #1248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/AppBundle/config/HotkeyBinding.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ import TOMLKit
@MainActor private var hotkeys: [String: HotKey] = [:]

@MainActor func resetHotKeys() {
// Explicitly unregister all hotkeys. We cannot always rely on destruction of the HotKey object to trigger
// unregistration because we might be running inside a hotkey handler that is keeping its HotKey object alive.
for (_, key) in hotkeys {
key.isEnabled = false
}
hotkeys = [:]
}

Expand Down
Loading