fix(client): replace server_version property with get_server_version() method#83
Merged
Merged
Conversation
…) method The async client exposed get_server_version() as a method; the sync client exposed server_version as a property, hiding the I/O cost. This inconsistency made the API misleading — property access should not trigger a network call. Changes: - Add get_server_version() to ConfigClient (same logic as the old property) - Deprecate the server_version property with DeprecationWarning pointing to get_server_version() - Update check_compatibility() to call get_server_version() directly - Update test suite: rename cached-fetch test, add deprecation-warning test Co-Authored-By: Claude <noreply@anthropic.com> Closes #52
zeevdr
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_versionon the sync client triggered a gRPC call on access, while the async client already used the explicit method formget_server_version().DeprecationWarningpointing callers to the new method.Test plan
test_client_get_server_version_cached— covers call-once-then-cache behavior viaget_server_version()test_client_server_version_property_deprecated— assertsDeprecationWarningis emitted with the correct message when accessing the propertycheck_compatibility()callsget_server_version()directly — existing pass/fail tests cover this204 passed,client.pyat 100% coverageCloses #52
🤖 Generated with Claude Code