Skip to content

Remove 'in progress' status from ecl-ec and add missing desy-v11 theme#10059

Merged
deleonio merged 3 commits intodevelopfrom
claude/fix-ecl-ec-desy-v11-radJb
Apr 25, 2026
Merged

Remove 'in progress' status from ecl-ec and add missing desy-v11 theme#10059
deleonio merged 3 commits intodevelopfrom
claude/fix-ecl-ec-desy-v11-radJb

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

  • Update ecl-ec display name from 'European Commission (in progress)' to 'European Commission'
  • Add missing DesyV11 theme import in presentation
  • Include DesyV11 in theme list for presentation app

https://claude.ai/code/session_01PCgaHWg67jK2Zd7KcD5iJa

claude added 2 commits April 25, 2026 04:06
- Update ecl-ec display name from 'European Commission (in progress)' to 'European Commission'
- Add missing DesyV11 theme import in presentation
- Include DesyV11 in theme list for presentation app

https://claude.ai/code/session_01PCgaHWg67jK2Zd7KcD5iJa
- Add theme-bwst to test matrix
- Add theme-desy to test matrix
- This enables visual regression testing for BWSt and Desy V11 themes

https://claude.ai/code/session_01PCgaHWg67jK2Zd7KcD5iJa
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the DesyV11 theme and updates the European Commission theme label to reflect its current status. Review feedback recommends sorting theme imports alphabetically for better organization and centralizing the theme configuration to eliminate duplication between the presentation and shared theme files.

Comment thread packages/samples/presentation/src/react.main.tsx Outdated
Comment thread packages/samples/presentation/src/react.main.tsx
Comment thread packages/samples/react/src/shares/theme.ts
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Martin Oppitz <6279703+deleonio@users.noreply.github.com>
@deleonio deleonio merged commit 54ea741 into develop Apr 25, 2026
9 of 12 checks passed
@deleonio deleonio deleted the claude/fix-ecl-ec-desy-v11-radJb branch April 25, 2026 04:10
@publicuibot publicuibot Bot locked and limited conversation to collaborators Apr 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants