Skip to content

Remove 'in progress' status from ecl-ec and add missing desy-v11 theme #10059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deleonio merged 3 commits into from
Apr 25, 2026
Merged

Remove 'in progress' status from ecl-ec and add missing desy-v11 theme #10059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4551203
Remove 'in progress' status from ecl-ec and add missing desy-v11 theme
claude Apr 25, 2026
7439360
Add missing theme packages to visual tests workflow
claude Apr 25, 2026
6f3c5df
Update packages/samples/presentation/src/react.main.tsx
deleonio Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/visual-tests-base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
visual-tests-snapshots:
strategy:
matrix:
package: ['test-tag-name-transformer', 'theme-default', 'theme-ecl', 'theme-kern']
package: ['test-tag-name-transformer', 'theme-default', 'theme-bwst', 'theme-ecl', 'theme-desy', 'theme-kern']
runs-on: ubuntu-latest
steps:
- name: Checkout base branch
Expand Down
6 changes: 3 additions & 3 deletions packages/samples/presentation/src/react.main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { HashRouter as Router } from 'react-router-dom';

import { bootstrap } from '@public-ui/components';
import { defineCustomElements } from '@public-ui/components/loader';
import { BWSt, DEFAULT, ECL_EC, ECL_EU, KERN_V2 } from '@public-ui/themes';
import { BWSt, DEFAULT, DesyV11, ECL_EC, ECL_EU, KERN_V2 } from '@public-ui/themes';

import { App } from '@public-ui/sample-react';

Expand All @@ -25,7 +25,7 @@ const getThemes = async () => {
}

/* List of regular sample app themes */
return [DEFAULT, BWSt, ECL_EC, ECL_EU, KERN_V2] as Theme[];
return [DEFAULT, BWSt, ECL_EC, ECL_EU, KERN_V2, DesyV11] as Theme[];
};

void (async () => {
Expand Down Expand Up @@ -85,7 +85,7 @@ void (async () => {
key: 'bwst',
},
{
name: 'European Commission (in progress)',
name: 'European Commission',
Comment thread
deleonio marked this conversation as resolved.
key: 'ecl-ec',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/react/src/shares/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const PUBLIC_THEMES: Theme[] = [
key: 'bwst',
},
{
name: 'European Commission (in progress)',
name: 'European Commission',
Comment thread
deleonio marked this conversation as resolved.
key: 'ecl-ec',
},
{
Expand Down
Loading