Skip to content

MNT Update unit tests for PHP 8.5#699

Merged
GuySartorelli merged 1 commit intosilverstripe:3from
creative-commoners:pulls/3/php85
Dec 2, 2025
Merged

MNT Update unit tests for PHP 8.5#699
GuySartorelli merged 1 commit intosilverstripe:3from
creative-commoners:pulls/3/php85

Conversation

@emteknetnz
Copy link
Copy Markdown
Member

@emteknetnz emteknetnz commented Nov 26, 2025

Issue silverstripe/.github#455

The following changes were made based on the PHP 8.5 changelog:

  • The setAccessible() methods of various Reflection objects have been deprecated, as those no longer have an effect.

@emteknetnz emteknetnz changed the title ENH PHP 8.5 Support MNT Update unit tests for PHP 8.5 Nov 26, 2025
@emteknetnz emteknetnz marked this pull request as ready for review December 1, 2025 02:26
Copy link
Copy Markdown
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit b9b92a5 into silverstripe:3 Dec 2, 2025
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/php85 branch December 2, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants