Skip to content

MNT Update unit tests for PHP 8.5 #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuySartorelli merged 1 commit into from
Dec 2, 2025
Merged

MNT Update unit tests for PHP 8.5 #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/php/FilenameParsing/HashFileIDHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ public function testRewriteVariantExtension($variant, $inFilename, $outFilename)
{
$helper = new HashFileIDHelper();
$reflectionMethod = new ReflectionMethod($helper, 'swapExtension');
$reflectionMethod->setAccessible(true);
$reflectionConst = new ReflectionClassConstant($helper, 'EXTENSION_VARIANT');
$actualFilename = $reflectionMethod->invoke($helper, $inFilename, $variant, $reflectionConst->getValue());

Expand All @@ -211,7 +210,6 @@ public function testRestoreOriginalExtension($variant, $outFilename, $inFilename
{
$helper = new HashFileIDHelper();
$reflectionMethod = new ReflectionMethod($helper, 'swapExtension');
$reflectionMethod->setAccessible(true);
$reflectionConst = new ReflectionClassConstant($helper, 'EXTENSION_ORIGINAL');
$actualFilename = $reflectionMethod->invoke($helper, $inFilename, $variant, $reflectionConst->getValue());

Expand Down
1 change: 0 additions & 1 deletion tests/php/Storage/Sha1FileHashingServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ public function testInvalidCharacterCacheKey()
Sha1FileHashingService::class,
'buildCacheKey'
);
$reflectedMethod->setAccessible(true);
// We're using this filename here as it was caught in issue #426
$cacheKey = $reflectedMethod->invokeArgs(
$service,
Expand Down
3 changes: 0 additions & 3 deletions tests/php/UploadTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ public function testAllowedSizeWontExceedPHPConfig()
{
$v = new Upload_Validator();
$reflectionMethod = new ReflectionMethod($v, 'maxUploadSizeFromPHPIni');
$reflectionMethod->setAccessible(true);
$maxUploadSize = $reflectionMethod->invoke($v);

// Bump up the size by about 2MB.
Expand All @@ -209,7 +208,6 @@ public function testWeFallBackToMaxPHPConfigIfEmptyArrayPassedForConfig()
{
$v = new Upload_Validator();
$reflectionMethod = new ReflectionMethod($v, 'maxUploadSizeFromPHPIni');
$reflectionMethod->setAccessible(true);
$maxUploadSize = $reflectionMethod->invoke($v);

$v->setAllowedMaxFileSize([]);
Expand All @@ -223,7 +221,6 @@ public function testWeHandleEmptyOrNullFileSizeValues()
{
$v = new Upload_Validator();
$reflectionMethod = new ReflectionMethod($v, 'maxUploadSizeFromPHPIni');
$reflectionMethod->setAccessible(true);
$maxUploadSize = $reflectionMethod->invoke($v);

/*
Expand Down
Loading