Skip to content

Protocol 23 integration#5717

Merged
urvisavla merged 32 commits intostellar:protocol-23from
urvisavla:p23-integration
Jun 12, 2025
Merged

Protocol 23 integration#5717
urvisavla merged 32 commits intostellar:protocol-23from
urvisavla:p23-integration

Conversation

@urvisavla
Copy link
Copy Markdown
Contributor

@urvisavla urvisavla commented Jun 5, 2025

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Bump core and rpc to protocol 23 and add protocol 23 to the integration test matrix.

This PR updates all integration tests to work with protocol 23 with the following exceptions:

Why

Adding protocol 23 support.

Known limitations

@urvisavla urvisavla force-pushed the p23-integration branch 3 times, most recently from f7ec5f9 to 3fb3ad2 Compare June 6, 2025 18:37
Bump core and rpc
@urvisavla urvisavla changed the title Bump core and rpc for P23 Protocol 23 integration Jun 11, 2025
@urvisavla urvisavla marked this pull request as ready for review June 11, 2025 06:29
Comment thread services/horizon/internal/integration/sac_test.go
Comment thread services/horizon/internal/integration/generate_ledgers_test.go Outdated
Comment thread services/horizon/internal/integration/invokehostfunction_test.go Outdated
Comment thread services/horizon/internal/integration/sac_test.go
Comment thread services/horizon/internal/integration/transaction_test.go
Copy link
Copy Markdown
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@urvisavla urvisavla force-pushed the p23-integration branch 3 times, most recently from fc8fecf to 24b7d05 Compare June 11, 2025 22:58
@urvisavla
Copy link
Copy Markdown
Contributor Author

The linter issue hasn't been resolved yet but I'm going to go ahead and merge this as few more PRs need to be added on top of this. will address the linter issue separately.

@urvisavla urvisavla merged commit f7e9089 into stellar:protocol-23 Jun 12, 2025
21 checks passed
@urvisavla urvisavla deleted the p23-integration branch June 12, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants