Small refactor to move call generation inside derive_pub_fn#1608
Merged
leighmcculloch merged 1 commit intomainfrom Oct 31, 2025
Merged
Small refactor to move call generation inside derive_pub_fn#1608leighmcculloch merged 1 commit intomainfrom
leighmcculloch merged 1 commit intomainfrom
Conversation
graydon
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move the token stream generation for function calls from the caller into the derive_pub_fn function itself, eliminating the call parameter from the function signature.
Why
This encapsulates the call generation logic within derive_pub_fn, reducing coupling and simplifying the function interface for callers. In a future change I'm working on where derive_pub_fn gets used in more places this will simplify the additional call sites not having to also define the call tokens. Minor refactor here in this PR rather than including it later to keep the later PRs hyperfocused on new functionality rather than a myriad of refactors.