Skip to content

Small refactor to move call generation inside derive_pub_fn #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leighmcculloch merged 1 commit into from
Oct 31, 2025
Merged

Small refactor to move call generation inside derive_pub_fn #1608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion soroban-sdk-macros/src/derive_fn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ use syn::{
pub fn derive_pub_fn(
crate_path: &Path,
impl_ty: &Type,
call: &TokenStream2,
ident: &Ident,
attrs: &[Attribute],
inputs: &Punctuated<FnArg, Comma>,
Expand All @@ -28,6 +27,8 @@ pub fn derive_pub_fn(
// Collect errors as they are encountered and emit them at the end.
let mut errors = Vec::<Error>::new();

let call = quote! { <super::#impl_ty>::#ident };

// Prepare the env input.
let env_input = inputs.first().and_then(|a| match a {
FnArg::Typed(pat_type) => {
Expand Down
2 changes: 0 additions & 2 deletions soroban-sdk-macros/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,11 +244,9 @@ pub fn contractimpl(metadata: TokenStream, input: TokenStream) -> TokenStream {
.iter()
.map(|m| {
let ident = &m.sig.ident;
let call = quote! { <super::#ty>::#ident };
derive_pub_fn(
crate_path,
&ty,
&call,
ident,
&m.attrs,
&m.sig.inputs,
Expand Down