Skip to content

🎨 Palette: Add ARIA labels to icon-only buttons in IdentityManager#215

Open
thebearwithabite wants to merge 1 commit intomasterfrom
palette-identity-manager-a11y-16880382698081319679
Open

🎨 Palette: Add ARIA labels to icon-only buttons in IdentityManager#215
thebearwithabite wants to merge 1 commit intomasterfrom
palette-identity-manager-a11y-16880382698081319679

Conversation

@thebearwithabite
Copy link
Copy Markdown
Owner

💡 What: Added aria-label, title, and standard focus-visible ring styling to the Edit, Delete, and Close dialog buttons in the IdentityManager settings component. The inner SVG icons were also marked with aria-hidden="true".

🎯 Why: These buttons contained only icons without visible text, making them completely inaccessible to screen reader users and confusing for keyboard navigators since they lacked focus rings or hover tooltips.

Accessibility:

  • Sighted users now get a helpful native tooltip on hover.
  • Screen readers will correctly announce "Edit [Name]", "Delete [Name]", or "Close dialog" instead of reading generic button roles or attempting to parse the SVG content.
  • Keyboard users receive a clear visual focus indicator when tabbing through the identity list.

PR created automatically by Jules for task 16880382698081319679 started by @thebearwithabite

Co-authored-by: thebearwithabite <216692431+thebearwithabite@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant