Skip to content

🎨 Palette: Add ARIA labels to icon-only buttons in IdentityManager #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thebearwithabite wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Add ARIA labels to icon-only buttons in IdentityManager #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions frontend_v2/src/components/settings/IdentityManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,15 +187,19 @@ export default function IdentityManager() {
<div className="flex gap-1">
<button
onClick={() => handleOpenDialog(identity)}
className="p-1.5 text-white/40 hover:text-white hover:bg-white/10 rounded-lg transition-colors"
className="p-1.5 text-white/40 hover:text-white hover:bg-white/10 rounded-lg transition-colors focus-visible:ring-2 focus-visible:ring-background/50 focus-visible:outline-none"
aria-label={`Edit ${identity.name}`}
title={`Edit ${identity.name}`}
>
<Edit2 size={14} />
<Edit2 size={14} aria-hidden="true" />
</button>
<button
onClick={() => handleDelete(identity.id)}
className="p-1.5 text-white/40 hover:text-red-400 hover:bg-red-400/10 rounded-lg transition-colors"
className="p-1.5 text-white/40 hover:text-red-400 hover:bg-red-400/10 rounded-lg transition-colors focus-visible:ring-2 focus-visible:ring-background/50 focus-visible:outline-none"
aria-label={`Delete ${identity.name}`}
title={`Delete ${identity.name}`}
>
<Trash2 size={14} />
<Trash2 size={14} aria-hidden="true" />
</button>
</div>
</div>
Expand Down Expand Up @@ -239,9 +243,11 @@ export default function IdentityManager() {
</h2>
<button
onClick={() => setIsDialogOpen(false)}
className="p-2 text-white/40 hover:text-white transition-colors"
className="p-2 text-white/40 hover:text-white transition-colors focus-visible:ring-2 focus-visible:ring-background/50 focus-visible:outline-none"
aria-label="Close dialog"
title="Close dialog"
>
<X size={20} />
<X size={20} aria-hidden="true" />
</button>
</div>

Expand Down
Loading