Ks 023 sep 23 figma icons 2047#2206
Merged
MuhammadKhalilzadeh merged 4 commits intodevelopfrom Sep 25, 2025
Merged
Conversation
- Replaced `@mui/icons-material/Speed` with `speed.svg`. - Updated imports and styles to integrate the new SVG icon.
- Replaced `@mui/icons-material/Edit` with `edit.svg`. - Updated imports and styles for seamless integration of the new SVG icon.
- Replaced `@mui/icons-material/TrendingUp`, `TrendingDown`, and `TrendingFlat` with `trendingUp.svg`, `trendingDown.svg`, and `trendingFlat.svg`. - Updated imports and adjusted styles for integration with new SVG icons.
solan117
added
enhancement
Contributor
WalkthroughReplaces Material UI icon imports/usage with project SVG ReactComponent icons in RiskMetricsCard, RisksCard, and Framework page; styling moved from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
Clients/src/presentation/components/Cards/RiskMetricsCard/index.tsx (1)
54-54: Size raw SVGs with width/height instead of fontSizefontSize typically won’t affect plain SVGs; set explicit dimensions for consistent rendering.
Apply this diff:
- <SpeedGreenIcon style={{ fontSize: 18}} /> + <SpeedGreenIcon style={{ width: 18, height: 18 }} aria-hidden />Clients/src/presentation/components/Cards/RisksCard/index.tsx (3)
28-28: Set explicit size on SVG icon (font-size won’t apply reliably)Use width/height so the icon renders as intended.
Apply this diff:
- <TrendingFlatGreyIcon style={trendIconStable} /> + <TrendingFlatGreyIcon style={{ ...trendIconStable, width: 14, height: 14 }} />
39-39: Set explicit size on SVG icon (font-size won’t apply reliably)Apply this diff:
- <TrendingUpRedIcon style={trendIconUp} /> + <TrendingUpRedIcon style={{ ...trendIconUp, width: 14, height: 14 }} />
49-49: Set explicit size on SVG icon (font-size won’t apply reliably)Apply this diff:
- <TrendingDownGreenIcon style={trendIconDown} /> + <TrendingDownGreenIcon style={{ ...trendIconDown, width: 14, height: 14 }} />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
Clients/src/presentation/assets/icons/edit.svgis excluded by!**/*.svgClients/src/presentation/assets/icons/speed.svgis excluded by!**/*.svgClients/src/presentation/assets/icons/trendingDown.svgis excluded by!**/*.svgClients/src/presentation/assets/icons/trendingFlat.svgis excluded by!**/*.svgClients/src/presentation/assets/icons/trendingUp.svgis excluded by!**/*.svg
📒 Files selected for processing (3)
Clients/src/presentation/components/Cards/RiskMetricsCard/index.tsx(2 hunks)Clients/src/presentation/components/Cards/RisksCard/index.tsx(4 hunks)Clients/src/presentation/pages/Framework/index.tsx(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
Clients/src/presentation/components/Cards/RisksCard/index.tsx (1)
Clients/src/presentation/components/Cards/RisksCard/style.ts (3)
trendIconStable(56-59)trendIconUp(46-49)trendIconDown(51-54)
🔇 Additional comments (3)
Clients/src/presentation/components/Cards/RiskMetricsCard/index.tsx (1)
2-2: LGTM: Swapped MUI Speed for SVG ReactComponentImport path and usage align with the PR objective.
Clients/src/presentation/pages/Framework/index.tsx (1)
19-19: LGTM: Replaced MUI Edit with SVG ReactComponentImport looks correct and consistent with the icon refactor.
Clients/src/presentation/components/Cards/RisksCard/index.tsx (1)
2-4: LGTM: Replaced MUI trend icons with SVGsImports look correct and scoped to the component.
MuhammadKhalilzadeh
approved these changes
Sep 25, 2025
This was referenced Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
refactor(icons): replace MUI Trending icons with custom SVGs
@mui/icons-material/TrendingUp,TrendingDown, andTrendingFlatwithtrendingUp.svg,trendingDown.svg, andtrendingFlat.svg.refactor(icons): replace MUI Edit icon with custom SVG edit icon
@mui/icons-material/Editwithedit.svg.refactor(icons): replace MUI Speed icon with custom SVG speed icon
@mui/icons-material/Speedwithspeed.svg.Write your issue number after "Fixes "
Fixes #2047
Please ensure all items are checked off before requesting a review: