-
Notifications
You must be signed in to change notification settings - Fork 55
Make internal node numbering consistent with input #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ischeider
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! Also the whole -"1 procedure" seems more consistent across the problem types.
|
This PR reveals loads of interesting things. I suspect we depend on some implicit numbering a lot more than we would like. Some observations:
|
|
@sebproell @mayrmt I'm almost certain the problem with the rising iteration numbers in contact is related to multigrid internals. In detail how aggregates are build on the contact interface ... seems to me this is still buggy as we internally calculate dofs from nodes (the numbering matters there, I didn't thought it has such an impact though). Test still passes as the overall procedure converges, but likely internally in the preconditioning something goes wrong. |
|
We should not depend on any numbering. However, there seem to be some very nasty dependencies on the zero-based numbering, and I am not sure I will be able to cleanly resolve these here. @maxfirmbach can you point me to the code where you think we do something questionable based on node numbering. Overall, getting this right seems even more important for the future robustness of the code base, now that we see how much it impacts existing code. |
|
@sebproell This piece of code lives in Trilinos itself ... I think @PhilipOesterlePekrun is already (indirectly) working on this here trilinos/Trilinos#13859 |
|
@sebproell @maxfirmbach there is currently work in progress to replace the degree of freedom dependent aggregation scheme by a node based aggregation scheme. This should not depend on any conversions between dofs and nodes. I expect this to be merged into Trilinos within the next couple of weeks |
|
@sebproell @maxfirmbach The necessary changes to Trilinos have been merged into Trilinos in the mean time. Necessary changes to 4C are work in progress, cf. #878, but require a Trilinos update in 4C in order to be mergable. |
This PR makes the internal node numbers equal to the node numbers specified in the dat-style or Exodus input.
Closes #731