- Add initial support for ARMv8A, ARMV7R and ARMV8R #45

Masmiseim36 · 2023-08-12T16:32:52Z

Added core_cxx.h files for ARMv8A, ARMV7R and ARMV8R based profiles
Moved gic peripheral to separate file
Moved __FPU_Enable function to the architecture specific file

github-actions · 2023-08-12T16:41:53Z

Test Results

264 files - 108 264 suites - 108 0s ⏱️ - 8m 47s
56 tests + 7 54 ✅ + 10 2 💤 - 3 0 ❌ ±0
14 292 runs - 3 936 12 124 ✅ +160 2 168 💤 - 4 096 0 ❌ ±0

Results for commit b77b700. ± Comparison against base commit d01c3e6.

This pull request removes 49 and adds 56 tests. Note that renamed tests count towards both.

CMSIS-Core.src ‑ apsr.c
CMSIS-Core.src ‑ basepri.c
CMSIS-Core.src ‑ bkpt.c
CMSIS-Core.src ‑ clrex.c
CMSIS-Core.src ‑ clz.c
CMSIS-Core.src ‑ control.c
CMSIS-Core.src ‑ cp15.c
CMSIS-Core.src ‑ cpsr.c
CMSIS-Core.src ‑ dmb.c
CMSIS-Core.src ‑ dsb.c
…

TC_CML1Cache_CleanDCacheByAddrWhileDisabled
TC_CML1Cache_EnDisableDCache
TC_CML1Cache_EnDisableICache
TC_CoreFunc_APSR
TC_CoreFunc_BASEPRI
TC_CoreFunc_Control
TC_CoreFunc_EnDisIRQ
TC_CoreFunc_EncDecIRQPrio
TC_CoreFunc_FAULTMASK
TC_CoreFunc_FPSCR
…

This pull request removes 5 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.

CMSIS-Core.src ‑ lda.c
CMSIS-Core.src ‑ ldaex.c
CMSIS-Core.src ‑ stl.c
CMSIS-Core.src ‑ stlex.c
CMSIS-Core.src ‑ systick.c

TC_CoreInstr_WFE
TC_CoreInstr_WFI

♻️ This comment has been updated with latest results.

JonatanAntoni · 2023-10-17T06:45:37Z

@Masmiseim36, could you please update this one with latest cleanups @GuentherMartin is working on, see PR #56.

CMSIS/Core/Include/r-profile/armv8r_cp15.h.h

CMSIS/Core/Include/r-profile/armv8r.h

CMSIS/Core/Include/r-profile/armv7r.h

CMSIS/Core/Include/a-profile/cmsis_armclang_a.h

CMSIS/Core/Include/a-profile/cmsis_gcc_a.h

ghost

are the CMSIS compiler include files missing in r-profile?

Masmiseim36 · 2023-10-22T16:42:28Z

are the CMSIS compiler include files missing in r-profile?

They come with this pull Request #44. That PR should be merged first
It makes it a bit difficult to break-up the changes in small chunks. I did the testing with the complete change than break it up again to have smaller Pull-Requests

JonatanAntoni · 2023-10-23T08:35:16Z

See PR #58 fixing the tests.

JonatanAntoni · 2024-04-29T09:38:37Z

Have you changed anything about the core checks? None of the Cortex-A projects build anymore, not even on the current unchanged head version. It seems that tests that are unsupported are counted as errors.

Not that I am aware of. PR workflow shall prevent that.
I just check main branch on my machine for all Cortex-A devices, all compilers and optimization modes without issues.

Please double check your environment. Mine was:

arm:compilers/arm/armclang 6.21.0  installed            Arm Compiler for Embedded
arm:compilers/arm/arm-none-eabi-gcc 13.2.1  installed            GCC compiler for ARM CPUs
arm:compilers/arm/llvm-embedded 17.0.1  installed            LLVM Embedded Toolchain for Arm CPUs

And after update:

arm:compilers/arm/armclang 6.22.0  installed            Arm Compiler for Embedded
arm:compilers/arm/arm-none-eabi-gcc 13.2.1  installed            GCC compiler for ARM CPUs
arm:compilers/arm/llvm-embedded 17.0.1  installed            LLVM Embedded Toolchain for Arm CPUs

Masmiseim36 · 2024-05-01T20:01:40Z

Hello @JonatanAntoni

the whole thing is a bit strange.

I have the same behavior locally as in this pull request, whether on this commit, the current head or on older versions: With the AC6 compiler all Cortex-A tests fail.

What makes the whole thing even stranger is that the errors only occur when I start all tests via ' build.py lit'. However, if I specify the compiler and target architecture, it works (build.py -c AC6 -d CA53 lit).

I had a similar problem before. Due to the lack of a license for AC6, every test that was not for Cortex-M0 failed. Since I have been using the MDK6 Community license, however, everything has been OK. Could this be a license problem again?

JonatanAntoni · 2024-05-02T07:04:33Z

Hi @Masmiseim36,

It probably is an licensing issue. The workflow for your PR runs in "isolation", i.e., it doesn't have access to the professional Arm license. Hence, all tests for Cortex-A and -R are supposed to fail.

Let me check your PR on my local machine. Then, I can recreate the PR with my maintainer privileges which gives it access to the license.

CMSIS/Core/Include/r-profile/cmsis_armclang_r.h

CMSIS/Core/Test/lit.cfg.py

Masmiseim36 · 2024-05-07T19:23:56Z

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

JonatanAntoni · 2024-05-08T06:07:15Z

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

ARM.CMSIS.pdsc

JonatanAntoni · 2024-05-13T13:35:40Z

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

The updated schema is now available at

https://raw.githubusercontent.com/Open-CMSIS-Pack/Open-CMSIS-Pack-Spec/v1.7.37/schema/PACK.xsd

Masmiseim36 · 2024-05-13T18:50:34Z

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

Any plans for 0.11.2 release?

JonatanAntoni · 2024-05-14T06:46:37Z

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

Any plans for 0.11.2 release?

What 0.11.2 release? The above PR to the pack schema has been merged and published via the schema version 1.3.37 tag.

Please update the schema reference in pdsc file at
https://github.com/ARM-software/CMSIS_6/pull/45/files#diff-2f515e4f53b33d558f9d7ef1cea041f96465055739878ea684a6f19dae2f84efR3

Masmiseim36 · 2024-05-14T20:46:18Z

The PR Open-CMSIS-Pack/Open-CMSIS-Pack-Spec#312 should solve the issues during pack generation

We need to update the pack schema reference URL in the pdsc file once this PR is merged.

Any plans for 0.11.2 release?

What 0.11.2 release? The above PR to the pack schema has been merged and published via the schema version 1.3.37 tag.

Please update the schema reference in pdsc file at https://github.com/ARM-software/CMSIS_6/pull/45/files#diff-2f515e4f53b33d558f9d7ef1cea041f96465055739878ea684a6f19dae2f84efR3

I have mixed the gen-pack version with the pack-spec version. Sorry for that

JonatanAntoni · 2024-06-03T08:55:37Z

ARM.CMSIS.pdsc

    </condition>
    <condition id="ARMv7-A Device">
-      <description>Armv7-A architecture based device</description>
+      <description>Armv7-A and Armv8-A architecture based device</description>


This description is misleading.

JonatanAntoni · 2024-06-03T08:55:55Z

ARM.CMSIS.pdsc

+      <accept Dcore="Cortex-A57"/>
+    </condition>
+    <condition id="ARMv7_8-A Device">
+      <description>Armv7_8-A architecture based device</description>


I guess the description from above belongs in here.

JonatanAntoni · 2025-11-12T14:20:43Z

Hi @Masmiseim36,

I think this PR won't receive much more features by now.
Do you still want to get it merged? If yes, could you check rebasing it to latest main then we could integrate it for upcoming CMSIS 6.3.0 release.

- Added core_cxx.h files for ARMv8A, ARMV7R and ARMV8R based profiles - Moved gic peripheral to separate file - Moved __FPU_Enable function to the architecture specific file - Extend core-test routines for new supported core-types

Masmiseim36 force-pushed the feature/AddInitialARMv8AandARMv7Rsupport branch from 8da3caa to 396c99a Compare August 21, 2023 16:48

Masmiseim36 mentioned this pull request Sep 29, 2023

Feature/use one core folder for all #26

Closed

JonatanAntoni requested a review from a user October 17, 2023 06:44