Skip to content

Allow simulation of more htan two GPS instances#28578

Merged
peterbarker merged 6 commits intoArduPilot:masterfrom
peterbarker:pr/sitl-gps-simulate-four
Nov 20, 2024
Merged

Allow simulation of more htan two GPS instances#28578
peterbarker merged 6 commits intoArduPilot:masterfrom
peterbarker:pr/sitl-gps-simulate-four

Conversation

@peterbarker
Copy link
Copy Markdown
Contributor

@peterbarker peterbarker commented Nov 11, 2024

Test with:

./Tools/autotest/sim_vehicle.py -v ArduPlane --gdb --debug --console  -A --serial5=sim:gps:3

No parameter conversion is done.

Parameters are moved to a subclass

Tested on branch for this PR: #28581

New requirements for testing RTK moving baseline - you must specify which is your "other" GPS as well as what sort of moving baseline thing you are.

@peterbarker peterbarker force-pushed the pr/sitl-gps-simulate-four branch from 4cce4e9 to dad086b Compare November 11, 2024 10:46
@peterbarker peterbarker removed the WIP label Nov 11, 2024
@peterbarker peterbarker force-pushed the pr/sitl-gps-simulate-four branch 7 times, most recently from 5c5cae6 to 139cbeb Compare November 13, 2024 00:56
Copy link
Copy Markdown
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close!

Comment thread libraries/SITL/SIM_GPS.cpp Outdated
#include <GCS_MAVLink/GCS.h>

namespace SITL {
// user settable parameters for airspeed sensors
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cut&paste?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

// @Description: Enabled GPS
// @Values: 0:Disable, 1:Enable
// @User: Advanced
AP_GROUPINFO_FLAGS("ENABLE", 1, GPSParms, enabled, 0, AP_PARAM_FLAG_ENABLE),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line in tables

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread libraries/SITL/SIM_GPS.cpp Outdated
// @Param: HDG
// @DisplayName: GPS Heading
// @Description: Enable GPS1 output of NMEA heading HDT sentence or UBLOX_RELPOSNED
// @Values: 0:Disabled, 1:Enabled
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not boolean?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documented

Comment thread libraries/SITL/SITL.h Outdated
GPS_HEADING_HDT = 1,
GPS_HEADING_THS = 2,
GPS_HEADING_KSXT = 3,
GPS_HEADING_BASE = 4, // nb. I'm guessing, this could be ROVER!
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs documenting

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this up - the enumeration name was correct.

@tridge tridge removed the DevCallEU label Nov 13, 2024
@peterbarker peterbarker force-pushed the pr/sitl-gps-simulate-four branch from 139cbeb to e996079 Compare November 18, 2024 00:18
@peterbarker peterbarker force-pushed the pr/sitl-gps-simulate-four branch from e996079 to 3b295ce Compare November 19, 2024 01:35
@peterbarker peterbarker merged commit ec1dc7c into ArduPilot:master Nov 20, 2024
@peterbarker peterbarker deleted the pr/sitl-gps-simulate-four branch November 20, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants