AP_Periph: added BatteryTag support#29983
Conversation
tridge
force-pushed
the
pr-BatteryTag
branch
3 times, most recently
from
78988a0 to
cb0fd13
Compare
| information about number of cycles a battery has been through along | ||
| with the serial number and number of hours in an armed state. | ||
|
|
||
| The log message in BTAG |
There was a problem hiding this comment.
Did you forget to finish a thought?
There was a problem hiding this comment.
Pretty sure this needs to be filled out with some
rmackay9
left a comment
rmackay9
left a comment
There was a problem hiding this comment.
I'm fine with this, thanks
Tools/AP_Periph/can.cpp
Outdated
| } | ||
|
|
||
|
|
||
| #if AP_PERIPH_RTC_ENABLED |
There was a problem hiding this comment.
| #if AP_PERIPH_RTC_ENABLED | |
| #if AP_PERIPH_RTC_GLOBALTIME_ENABLED |
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
Apart from the define request I've made, I think this looks really good.
I have reservations about the global time message, but it's nowhere near as big an issue if we're not locked into it in the main firmware.
|
@peterbarker added AP_PERIPH_RTC_GLOBALTIME_ENABLED |
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
LGTM. Just a few comment problems now.
Tools/AP_Periph/battery_tag.cpp
Outdated
| battery info support. This feature has a set of parameters which are | ||
| controlled by a lua script on the FMU. The battery infomation node | ||
| is attached to a specific battery and recorded the number of cycles, | ||
| and total armed time |
There was a problem hiding this comment.
Not sure this is entirely accurate now.
| information about number of cycles a battery has been through along | ||
| with the serial number and number of hours in an armed state. | ||
|
|
||
| The log message in BTAG |
There was a problem hiding this comment.
Pretty sure this needs to be filled out with some
this implements a battery tag node that is permanently attached to a battery to give information on armed hours and cycles
6 participants
This adds support for BatteryTag functionality in AP_Periph, along with a lua script for logging and handling battery tags.
A batterytag is a DroneCAN node that is permanently attached to the battery to record battery cycles and armed time. It is helpful for managing battery lifetime. Note that the batterytag may not have access to the battery voltage/current/state-of-charge
split from #29310 as requested by @tpwrules