Skip to content

AP_NavEKF3: remove primary-core-only logging #30880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AP_NavEKF3: remove primary-core-only logging #30880

wants to merge 1 commit into from
+0 −20

Conversation

rishabsingh3003
Copy link
Contributor

This has come in the way of some logs I have been analysing

rmackay9
rmackay9 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the only reason not to merge this is due to concerns over log size.

peterbarker
peterbarker approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also bit us in Canberra a couple of times.

tridge
tridge requested changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would massively increase log sizes. Adding a EK3_OPTIONS bit to log all lanes would be great, but doing this for everyone will just lead to huge logs

@LupusTheCanine
Copy link

LupusTheCanine commented Aug 11, 2025 •
edited
Loading

this would massively increase log sizes. Adding a EK3_OPTIONS bit to log all lanes would be great, but doing this for everyone will just lead to huge logs

Well, log bitmask definitely lacks granularity. I got bit a few times by bits disabling seemingly unrelated messages.

@peterbarker
Copy link
Contributor

Perhaps we could skip logging this if the user isn't actually doing optical flow stuff?

@rishabsingh3003
Copy link
Contributor Author

Perhaps we could skip logging this if the user isn't actually doing optical flow stuff?

The XKF5 logging is a bit weird. It seems to log both Optical Flow and some other things. I think it might be useful to break XKF5 into two chunks? I.e, a seperate log just for EKF optical flow stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge requested changes

@rmackay9 rmackay9 rmackay9 approved these changes

@peterbarker peterbarker peterbarker approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rishabsingh3003 @LupusTheCanine @peterbarker @tridge @rmackay9