ArduSub/mode_acro: fix bug for dealing throttle from pilot#31469
Merged
Williangalvani merged 1 commit intoArduPilot:masterfrom Feb 5, 2026
Merged
Conversation
peterbarker
reviewed
Nov 9, 2025
|
|
||
| // output pilot's throttle without angle boost | ||
| attitude_control->set_throttle_out(channel_throttle->norm_input(), false, g.throttle_filt); | ||
| attitude_control->set_throttle_out((channel_throttle->norm_input() + 1.0f) / 2.0f, false, g.throttle_filt); |
Contributor
There was a problem hiding this comment.
This isn't just reverse thrust being a thing on subs?
Williangalvani
approved these changes
Feb 5, 2026
Contributor
Williangalvani
left a comment
Williangalvani
left a comment
There was a problem hiding this comment.
Thanks! it is hard to believe we had this bug for this long!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix mistake for getting throttle values from pilot