AP_Baro: correct duplication check for i2c baro devices #31839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
requested changes
Jan 2, 2026
libraries/AP_Baro/AP_Baro.cpp
Outdated
| /* | ||
| wrapper around hal.i2c_mgr->get_device() that prevents duplicate devices being opened | ||
| */ | ||
| bool AP_Baro::_have_i2c_driver(uint8_t bus, uint8_t address) const |
Contributor
There was a problem hiding this comment.
I think the reason this might have occurred is the bad naming of this method, I think you should change it to _have_i2c_device as well
Contributor
Author
There was a problem hiding this comment.
I've created #31845 where all of the inevitable bike-sheeding can occur.
I'd rather not hold this up for that no-compiler-output change.
we're indexing into the sensors array, so we should only iterate up to the number of sensors we have could be a problem if there are DroneCAN backends involved as that can cause a mismatch between _num_sensors and _num_drivers
peterbarker
force-pushed
the
pr/baro-iteration-count-wrong
branch
from
3b65760 to
46ec569
Compare
andyp1per
approved these changes
Jan 6, 2026
github-project-automation
bot
moved this from ReadyForDevCall
to Done
in Peter's ArduPilot 4.7 Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're indexing into the sensors array, so we should only iterate up to the number of sensors we have
could be a problem if there are DroneCAN backends involved as that can cause a mismatch between _num_sensors and _num_drivers