-
Notifications
You must be signed in to change notification settings - Fork 20.2k
add separate double and float implementations for wrap_PI and wrap_2PI #31971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tridge
merged 3 commits into
ArduPilot:master
from
peterbarker:pr/separate-wrap_PI-double-float
Jan 28, 2026
Merged
add separate double and float implementations for wrap_PI and wrap_2PI #31971
tridge
merged 3 commits into
ArduPilot:master
from
peterbarker:pr/separate-wrap_PI-double-float
Jan 28, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
a44fdfe to
ff35693
Compare
…d wrap_2PI avoids double promotion when the argument is not double
tridge
requested changes
Jan 27, 2026
libraries/AP_Math/AP_Math.cpp
Outdated
| } | ||
|
|
||
| template float wrap_PI<float>(const float radian); | ||
| #if AP_MATH_ALLOW_DOUBLE_FUNCTIONS |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't make sense to use this define in AP_Math.cpp, its not a project level define, its per cpp file
ff35693 to
38bf47d
Compare
Contributor
Author
After removing defines.... |
tridge
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids double promotion when the argument is not double