Skip to content

GCS_MAVLink: use att_pos_mocap covariance and fix extnav pos, ang err calculation#32084

Merged
peterbarker merged 2 commits intoArduPilot:masterfrom
chobitsfan:pr_fix_covariance
Feb 5, 2026
Merged

GCS_MAVLink: use att_pos_mocap covariance and fix extnav pos, ang err calculation#32084
peterbarker merged 2 commits intoArduPilot:masterfrom
chobitsfan:pr_fix_covariance

Conversation

@chobitsfan
Copy link
Contributor

  1. Currently, the covariance field in ATT_POS_MOCAP is not used. This PR enables its usage, similar to what is already done in VISION_POSITION_ESTIMATE.
  2. The current pose uncertainty calculation (posErr, angErr) appears to be incorrect. In a covariance matrix, the diagonal elements represent variances (i.e., squared quantities). Therefore, posErr should be computed as sqrt(covariance[0] + covariance[6] + covariance[11]).

flight log, ext nav data from kimera-vio
pr_fix_cov.zip
https://youtu.be/p1hQZSN-gU0

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit 0122854 into ArduPilot:master Feb 5, 2026
112 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants