[ Tools ] : move logger documentation validation to standalone script#32111
Closed
Dijo-404 wants to merge 1 commit intoArduPilot:masterfrom
Closed
[ Tools ] : move logger documentation validation to standalone script#32111Dijo-404 wants to merge 1 commit intoArduPilot:masterfrom
Dijo-404 wants to merge 1 commit intoArduPilot:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors logger documentation validation by moving it from the autotest suite into a standalone script, addressing issue #17579. The change enables earlier validation in the CI pipeline without requiring the full autotest suite to run.
Changes:
- Created
Tools/autotest/logger_metadata/validate.pyas a standalone script that combines documentation generation (via parse.py) with validation logic - Simplified
LoggerDocumentation()invehicle_test_suite.pyto call the new validate.py script instead of performing validation inline - Updated
build_ci.shlogger_metadata target to use validate.py instead of parse.py
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| Tools/autotest/logger_metadata/validate.py | New standalone script that generates and validates logger documentation for all vehicles |
| Tools/autotest/vehicle_test_suite.py | Refactored LoggerDocumentation() method to delegate to standalone validate.py script |
| Tools/scripts/build_ci.sh | Updated CI build script to call validate.py instead of parse.py for logger_metadata target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Extracted validation logic from vehicle_test_suite.py to validate.py - Improved temp directory cleanup - Added Helicopter whitelist support - Fixed KeyError during validation
Dijo-404
force-pushed
the
fix/move-logging-validation
branch
from
59d5f3d to
7b7a1e7
Compare
Contributor
|
Sorry, I think you mis-understood the issue. This was done in 9e4bdf3 Feel free to create another PR to fix the Blimp problems you saw. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17579
Note: I noticed that there are pre-existing undocumented messages in Blimp (BSC, VNF) which cause a failure in the CI logger_metadata target. This is a known issue within the Blimp vehicle code and is not introduced by this PR's move to a standalone script.
Blimp issue
validate.py
