Fixed multitype list #1076
Merged
Fixed multitype list #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thankyou |
AtsushiSakai
requested changes
Dec 20, 2024
There was a problem hiding this comment.
@AryazE Sorry. Can you modify all the scripts to use floats?
AtsushiSakai
requested changes
Dec 21, 2024
There was a problem hiding this comment.
Sorry, I think some changes should be rollbacked. PTAL. @AryazE
| print(__file__ + " start!!") | ||
|
|
||
| # start and goal position | ||
| sx = 10.0 # [m] |
There was a problem hiding this comment.
sorry, we can keep these float parameters as before.
| sy = -5.0 # [m] | ||
| gx = 50.0 # [m] | ||
| gy = 50.0 # [m] | ||
| grid_size = 2.0 # [m] |
There was a problem hiding this comment.
sorry, we can keep these float parameters as before.
| sy = 10.0 # [m] | ||
| gx = 50.0 # [m] | ||
| gy = 50.0 # [m] | ||
| robot_size = 5.0 # [m] |
There was a problem hiding this comment.
sorry, we can keep these float parameters as before.
| sy = 10.0 # [m] | ||
| gx = 50.0 # [m] | ||
| gy = 50.0 # [m] | ||
| robot_size = 5.0 # [m] |
There was a problem hiding this comment.
sorry, we can keep these float parameters as before.
|
@AryazE Is it possible to finish this PR? |
|
Done! Thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
What does this implement/fix?
This PR ensures that the lists provided to some path planning algorithms are all
ints and not a mix offloatandint.Additional information
CheckList