-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Extend frenet_optimal_trajectory to support more scenarios #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aglargil Thank you for your PR and sorry for late review.
I have some comments, PTAL.
And I will be very happy if you can update this doc to explain this algorithm and simulations:
https://github.com/AtsushiSakai/PythonRobotics/blob/master/docs/modules/path_planning/frenet_frame_path/frenet_frame_path_main.rst
PathPlanning/FrenetOptimalTrajectory/cartesian_frenet_converter.py
Outdated
Show resolved
Hide resolved
Thank you for your reply, I will address the comments within a day! |
@AtsushiSakai I've updated it, so if there are any other suggestions, please alert me and I'll get right on it! |
PathPlanning/FrenetOptimalTrajectory/frenet_optimal_trajectory.py
Outdated
Show resolved
Hide resolved
PathPlanning/FrenetOptimalTrajectory/frenet_optimal_trajectory.py
Outdated
Show resolved
Hide resolved
PathPlanning/FrenetOptimalTrajectory/frenet_optimal_trajectory.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Than you!!
Reference issue
fix #1073
What does this implement/fix?
CartesianFrenetConverter
: A class for converting states between Cartesian and Frenet coordinate systemsCubicSpline
LateralMovementStrategy
, add MergingAndStopping/VelocityKeepingLongitudinalMovementStrategy
s_d
was used as the acceleration, but sinces_d
only represents the longitudinal acceleration, theCartesianFrenetConverter
is now used to compute the accelerationa
consistentlyAdditional information
CheckList