Skip to content

Conversation

@jeffrymsft
Copy link
Contributor

@jeffrymsft jeffrymsft commented Feb 7, 2025

Version Updates:

  • Updated JDK to version 1.17.
  • Upgraded Gradle to version 8.1.1.
  • Changed Gradle distribution URL to 8.1-all.
  • msal4j upgraded to 1.20.1

Dependency Updates:

  • Updated build system plugin to version 0.2.5.

Build Configuration Changes:

  • Added namespace properties in build.gradle files as per the new Gradle feature.
  • Updated Gradle task configurations to use new properties.
  • Adjusted Maven publishing configurations for different build types.
  • Removed deprecated properties and replaced them with updated ones.

Android Manifest Changes:

  • Commented out package declarations to align with the namespace property requirements in Gradle.

Pipeline and CI/CD Updates:

  • Updated Gradle tasks to use Java 17 home directory.
  • Adjusted JDK version in pipeline tasks from 1.11 to 1.17.

Common PR: #2587
MSAL PR: AzureAD/microsoft-authentication-library-for-android#2254
ADAL PR: AzureAD/azure-activedirectory-library-for-android#1821
Azuresample PR: Azure-Samples/ms-identity-android-java#85
AB#2779502

@jeffrymsft jeffrymsft requested a review from a team as a code owner February 7, 2025 18:50
@github-actions
Copy link

github-actions bot commented Feb 7, 2025

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@jeffrymsft jeffrymsft force-pushed the gradleVersionChange2 branch 2 times, most recently from c253fee to caf8396 Compare March 1, 2025 10:26
@jeffrymsft jeffrymsft force-pushed the gradleVersionChange2 branch from fcfad98 to 8c8b295 Compare March 14, 2025 19:47
@jeffrymsft jeffrymsft force-pushed the gradleVersionChange2 branch 3 times, most recently from f48793b to 55f0463 Compare March 26, 2025 19:45
Copy link
Contributor

@shahzaibj shahzaibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a bunch of commented out code throughout the PR. If this code is no longer needed then let's remove it and I'll review again once done

@jeffrymsft jeffrymsft force-pushed the gradleVersionChange2 branch 4 times, most recently from bfeb3ff to 2c23143 Compare April 9, 2025 21:08
@jeffrymsft jeffrymsft force-pushed the gradleVersionChange2 branch 3 times, most recently from 8a64c77 to 52ba4a0 Compare April 17, 2025 01:23
@jeffrymsft jeffrymsft force-pushed the gradleVersionChange2 branch from b237781 to 19e3f35 Compare April 25, 2025 18:52
@fadidurah fadidurah merged commit 63f5f77 into dev May 27, 2025
18 of 20 checks passed
somalaya added a commit that referenced this pull request May 27, 2025
somalaya added a commit that referenced this pull request May 28, 2025
somalaya added a commit that referenced this pull request Jun 23, 2025
Reverts #2651

Same as this PR created by Jeffrey --
#2587

I previously merged the above PR and realized that it was some extra
changes were needed in related broker PR and there was not enough time
to make the changes, So I reverted it.

Successful builds : 
common4j Build and Test :
https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1493462&view=results
common Build and Test :
https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1493463&view=results

Fixes
[AB#2779502](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/2779502)
somalaya added a commit to AzureAD/microsoft-authentication-library-for-android that referenced this pull request Jun 23, 2025
Version Updates:
- Updated JDK to version 1.17.
- Upgraded Gradle to version 8.1.1.
- Changed Gradle distribution URL to 8.1-all.

Dependency Updates:
- Updated build system plugin to version 0.2.5.

Build Configuration Changes:
- Added namespace properties in build.gradle files as per the new Gradle
feature.
- Updated Gradle task configurations to use new properties.
- Adjusted Maven publishing configurations for different build types.
- Removed deprecated properties and replaced them with updated ones.

Android Manifest Changes:
- Commented out package declarations to align with the namespace
property requirements in Gradle.

Pipeline and CI/CD Updates:
- Updated Gradle tasks to use Java 17 home directory.
- Adjusted JDK version in pipeline tasks from 1.11 to 1.17.

Working Pipeline runs using my branch of common: 
MSAL -Build and Test:
https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1466968&view=results


Common PR:
AzureAD/microsoft-authentication-library-common-for-android#2587
MSAL PR:
#2254
Broker PR: https://github.com/AzureAD/ad-accounts-for-android/pull/3052
Azuresample PR:
Azure-Samples/ms-identity-android-java#85

[AB#2779502](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/2779502)

---------

Co-authored-by: Sowmya Malayanur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Consumers-Check Only include this if making a breaking change purposefully, and there is an MSAL/ADAL/Broker PR