-
Notifications
You must be signed in to change notification settings - Fork 46
Gradle version change from AGP 7.4.2 to 8.1.1, Fixes AB#2779502 #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
6c1fd18 to
591137b
Compare
c253fee to
caf8396
Compare
fcfad98 to
8c8b295
Compare
f48793b to
55f0463
Compare
shahzaibj
reviewed
Apr 2, 2025
shahzaibj
reviewed
Apr 2, 2025
shahzaibj
reviewed
Apr 2, 2025
shahzaibj
reviewed
Apr 2, 2025
shahzaibj
reviewed
Apr 2, 2025
shahzaibj
reviewed
Apr 2, 2025
shahzaibj
reviewed
Apr 2, 2025
Contributor
shahzaibj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing a bunch of commented out code throughout the PR. If this code is no longer needed then let's remove it and I'll review again once done
shahzaibj
reviewed
Apr 2, 2025
shahzaibj
reviewed
Apr 2, 2025
bfeb3ff to
2c23143
Compare
shahzaibj
reviewed
Apr 10, 2025
.../com/microsoft/identity/common/internal/platform/AndroidDevicePoPManagerEncryptionTests.java
Outdated
Show resolved
Hide resolved
somalaya
reviewed
Apr 10, 2025
somalaya
reviewed
Apr 10, 2025
somalaya
reviewed
Apr 10, 2025
somalaya
reviewed
Apr 10, 2025
8a64c77 to
52ba4a0
Compare
b237781 to
19e3f35
Compare
somalaya
approved these changes
May 15, 2025
fadidurah
approved these changes
May 15, 2025
somalaya
added a commit
that referenced
this pull request
May 28, 2025
…02" (#2651) Reverts #2587 Reverting since the builds are failing after this change. Fixes [AB#2779502](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/2779502)
somalaya
added a commit
that referenced
this pull request
Jun 23, 2025
Reverts #2651 Same as this PR created by Jeffrey -- #2587 I previously merged the above PR and realized that it was some extra changes were needed in related broker PR and there was not enough time to make the changes, So I reverted it. Successful builds : common4j Build and Test : https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1493462&view=results common Build and Test : https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1493463&view=results Fixes [AB#2779502](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/2779502)
somalaya
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
Jun 23, 2025
Version Updates: - Updated JDK to version 1.17. - Upgraded Gradle to version 8.1.1. - Changed Gradle distribution URL to 8.1-all. Dependency Updates: - Updated build system plugin to version 0.2.5. Build Configuration Changes: - Added namespace properties in build.gradle files as per the new Gradle feature. - Updated Gradle task configurations to use new properties. - Adjusted Maven publishing configurations for different build types. - Removed deprecated properties and replaced them with updated ones. Android Manifest Changes: - Commented out package declarations to align with the namespace property requirements in Gradle. Pipeline and CI/CD Updates: - Updated Gradle tasks to use Java 17 home directory. - Adjusted JDK version in pipeline tasks from 1.11 to 1.17. Working Pipeline runs using my branch of common: MSAL -Build and Test: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1466968&view=results Common PR: AzureAD/microsoft-authentication-library-common-for-android#2587 MSAL PR: #2254 Broker PR: https://github.com/AzureAD/ad-accounts-for-android/pull/3052 Azuresample PR: Azure-Samples/ms-identity-android-java#85 [AB#2779502](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/2779502) --------- Co-authored-by: Sowmya Malayanur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Skip-Consumers-Check
Only include this if making a breaking change purposefully, and there is an MSAL/ADAL/Broker PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version Updates:
Dependency Updates:
Build Configuration Changes:
Android Manifest Changes:
Pipeline and CI/CD Updates:
Common PR: #2587
MSAL PR: AzureAD/microsoft-authentication-library-for-android#2254
ADAL PR: AzureAD/azure-activedirectory-library-for-android#1821
Azuresample PR: Azure-Samples/ms-identity-android-java#85
AB#2779502