Skip to content

Upgrading the AGP Version from 7.4.2 to 8.1.1, Fixes AB#2779502 #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
somalaya merged 39 commits into from
Jun 23, 2025
Merged

Upgrading the AGP Version from 7.4.2 to 8.1.1, Fixes AB#2779502 #2254

somalaya merged 39 commits into from
Jun 23, 2025

Conversation

@jeffrymsft
Copy link
Contributor

@jeffrymsft jeffrymsft commented Feb 5, 2025 •
edited
Loading

Version Updates:

  • Updated JDK to version 1.17.
  • Upgraded Gradle to version 8.1.1.
  • Changed Gradle distribution URL to 8.1-all.

Dependency Updates:

  • Updated build system plugin to version 0.2.5.

Build Configuration Changes:

  • Added namespace properties in build.gradle files as per the new Gradle feature.
  • Updated Gradle task configurations to use new properties.
  • Adjusted Maven publishing configurations for different build types.
  • Removed deprecated properties and replaced them with updated ones.

Android Manifest Changes:

  • Commented out package declarations to align with the namespace property requirements in Gradle.

Pipeline and CI/CD Updates:

  • Updated Gradle tasks to use Java 17 home directory.
  • Adjusted JDK version in pipeline tasks from 1.11 to 1.17.

Working Pipeline runs using my branch of common:
MSAL -Build and Test: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1466968&view=results

Common PR: AzureAD/microsoft-authentication-library-common-for-android#2587
MSAL PR: #2254
Broker PR: https://github.com/AzureAD/ad-accounts-for-android/pull/3052
Azuresample PR: Azure-Samples/ms-identity-android-java#85
AB#2779502

@jeffrymsft jeffrymsft force-pushed the gradleChangeVersion2 branch from 6ed0516 to ede9983 Compare February 6, 2025 22:26
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@jeffrymsft jeffrymsft force-pushed the gradleChangeVersion2 branch from f3100f9 to 6264865 Compare February 7, 2025 23:24
@jeffrymsft jeffrymsft force-pushed the gradleChangeVersion2 branch from 160bbc8 to 33b9cdb Compare March 18, 2025 22:54
@jeffrymsft jeffrymsft force-pushed the gradleChangeVersion2 branch from 782497d to a157013 Compare March 26, 2025 21:58
somalaya
somalaya reviewed Mar 28, 2025
View reviewed changes
somalaya
somalaya reviewed Mar 28, 2025
View reviewed changes
somalaya
somalaya reviewed Mar 28, 2025
View reviewed changes
somalaya
somalaya reviewed Mar 28, 2025
View reviewed changes
gradle/versions.gradle
ext {
// SDK
minSdkVersion = 16
minSdkVersion = 21
Copy link
Contributor

@somalaya somalaya Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intend to change minSdkVersion to 21? I believe this change is here because of a rebase?

Copy link
Contributor Author

@jeffrymsft jeffrymsft Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I needed this because of Pedros update in common and msal which forced the upgrade. Should I seperate it?

Copy link
Contributor

@shahzaibj shahzaibj Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be showing up here because Jeffrey's branch isn't up to date with dev. @jeffrymsft Can you update your branch with latest dev?

somalaya
somalaya reviewed Mar 28, 2025
View reviewed changes
@jeffrymsft jeffrymsft marked this pull request as ready for review March 28, 2025 16:56
@jeffrymsft jeffrymsft requested a review from a team as a code owner March 28, 2025 16:56
@jeffrymsft jeffrymsft force-pushed the gradleChangeVersion2 branch from 7245732 to 3d1c8ea Compare April 2, 2025 22:48
somalaya
somalaya reviewed Apr 10, 2025
View reviewed changes
azure-pipelines/pull-request-validation/pr-msal.yml Outdated
type: github
name: AzureAD/microsoft-authentication-library-common-for-android
ref: dev
ref: gradleVersionChange2
Copy link
Contributor

@somalaya somalaya Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you are done with your testing. you would be reverting this right back to dev right?

Copy link
Contributor Author

@jeffrymsft jeffrymsft Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Collaborator

@fadidurah fadidurah Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

@jeffrymsft jeffrymsft Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be changing these once I'm convinced everything will merge.

somalaya
somalaya reviewed Apr 10, 2025
View reviewed changes
msal/build.gradle Outdated
@@ -1,5 +1,5 @@
plugins {
id 'com.microsoft.identity.buildsystem' version '0.2.3'
id 'com.microsoft.identity.buildsystem' version '0.2.4-1'
Copy link
Contributor

@somalaya somalaya Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to 0.2.5

somalaya
somalaya reviewed Apr 10, 2025
View reviewed changes
@jeffrymsft jeffrymsft force-pushed the gradleChangeVersion2 branch from c07c706 to d54d6be Compare April 11, 2025 17:15
@jeffrymsft jeffrymsft requested a review from a team as a code owner April 16, 2025 22:25
@jeffrymsft jeffrymsft changed the title Gradle change version2 Upgrading the AGP Version from 7.4.2 to 8.1.1 Apr 17, 2025
@jeffrymsft jeffrymsft force-pushed the gradleChangeVersion2 branch from f98c534 to a864418 Compare April 17, 2025 17:05
@jeffrymsft jeffrymsft mentioned this pull request Apr 17, 2025
Merged
@jeffrymsft jeffrymsft force-pushed the gradleChangeVersion2 branch from a864418 to 5874f12 Compare April 17, 2025 17:41
@github-actions github-actions bot changed the title Upgrading the AGP Version from 7.4.2 to 8.1.1 Upgrading the AGP Version from 7.4.2 to 8.1.1, Fixes AB#2779502 Apr 17, 2025
@jeffrymsft jeffrymsft mentioned this pull request Apr 17, 2025
Merged
fadidurah
fadidurah reviewed Apr 17, 2025
View reviewed changes
@somalaya somalaya force-pushed the gradleChangeVersion2 branch from 82bb201 to 67c03be Compare June 23, 2025 16:24
@somalaya
Copy link
Contributor

somalaya commented Jun 23, 2025

@microsoft-github-policy-service agree

@somalaya
Copy link
Contributor

somalaya commented Jun 23, 2025

@microsoft-github-policy-service agree company="Microsoft"

@somalaya somalaya mentioned this pull request Jun 23, 2025
Closed
@somalaya somalaya merged commit c553208 into dev Jun 23, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzaibj shahzaibj shahzaibj left review comments

Copilot code review Copilot Copilot left review comments

@somalaya somalaya somalaya approved these changes

@fadidurah fadidurah fadidurah approved these changes

Assignees

No one assigned

Labels

msal package-inspector pop-benchmarker test-automation testapps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffrymsft @somalaya @shahzaibj @fadidurah