-
Notifications
You must be signed in to change notification settings - Fork 5
Update spherex_qr -> spherex_qr2 #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bsipocz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text is likely needs to be updated, too.
Co-authored-by: Brigitta Sipőcz <[email protected]>
|
I added a couple of simplifications and fixes for minor things in the SPHEREx notebooks. The only build-docs error right now is an IndexError in spherex_intro.md due to this PR which is expected until QR2 is available in SIA. ETA is end of this week or early next. After that happens, need to test this against ops before merging. |
9238b7a to
595bef0
Compare
|
All three SPHEREx notebooks run successfully on Fornax. However, spherex_cutouts.md is failing the circleci build with the following error. I am investigating. |
|
CircleCI failure was transitory. Not sure what happened but all looks good now. This is ready to go. |
bsipocz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ready to go.
The traceback sometimes is incorrect as the error/unexpected behaviour occurs a few lines above, I suspect a non-tracebacking query was the culprit for that sporadic failure you saw.
Closes IRSA-7323
Closes IRSA-7363
Do not merge until SPHEREx QR2 has been released and is available in SIA.
SPHEREx QR2 is scheduled to be released on October
1416, available in SIA a day or two later. This PR updates notebooks to use it. I think that only the collections names will need to be updated but we'll need to test this once QR2 is available in SIA on irsatest, likely on October 13.