Skip to content

Conversation

@troyraen
Copy link
Contributor

@troyraen troyraen commented Oct 6, 2025

Closes IRSA-7323
Closes IRSA-7363

Do not merge until SPHEREx QR2 has been released and is available in SIA.

SPHEREx QR2 is scheduled to be released on October 1416, available in SIA a day or two later. This PR updates notebooks to use it. I think that only the collections names will need to be updated but we'll need to test this once QR2 is available in SIA on irsatest, likely on October 13.

@troyraen troyraen added the content: spherex Content related issues/PRs for notebooks with SPHEREx relevance label Oct 6, 2025
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is likely needs to be updated, too.

Co-authored-by: Brigitta Sipőcz <[email protected]>
@troyraen
Copy link
Contributor Author

I added a couple of simplifications and fixes for minor things in the SPHEREx notebooks. The only build-docs error right now is an IndexError in spherex_intro.md due to this PR which is expected until QR2 is available in SIA. ETA is end of this week or early next. After that happens, need to test this against ops before merging.

@troyraen troyraen mentioned this pull request Oct 24, 2025
@troyraen troyraen force-pushed the raen/IRSA-7323/spherex-qr2 branch from 9238b7a to 595bef0 Compare October 24, 2025 19:05
@troyraen
Copy link
Contributor Author

All three SPHEREx notebooks run successfully on Fornax. However, spherex_cutouts.md is failing the circleci build with the following error. I am investigating.

⛔️ tutorials/spherex/spherex_cutouts.md An exception occurred during code execution, halting further execution:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[9], line 3
      1 primary_hdu = fits.PrimaryHDU()
      2 hdulist_list = [primary_hdu, table_hdu]
----> 3 hdulist_list.extend(hdu for fits_hdulist in results_table_parallel["hdus"] for hdu in fits_hdulist)
      4 combined_hdulist = fits.HDUList(hdulist_list)

Cell In[9], line 3, in <genexpr>(.0)
      1 primary_hdu = fits.PrimaryHDU()
      2 hdulist_list = [primary_hdu, table_hdu]
----> 3 hdulist_list.extend(hdu for fits_hdulist in results_table_parallel["hdus"] for hdu in fits_hdulist)
      4 combined_hdulist = fits.HDUList(hdulist_list)

TypeError: 'NoneType' object is not iterable

@troyraen
Copy link
Contributor Author

CircleCI failure was transitory. Not sure what happened but all looks good now. This is ready to go.

@troyraen troyraen marked this pull request as ready for review October 24, 2025 19:36
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to go.

The traceback sometimes is incorrect as the error/unexpected behaviour occurs a few lines above, I suspect a non-tracebacking query was the culprit for that sporadic failure you saw.

@bsipocz bsipocz merged commit 03f995b into main Oct 24, 2025
8 checks passed
@bsipocz bsipocz deleted the raen/IRSA-7323/spherex-qr2 branch October 24, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content: spherex Content related issues/PRs for notebooks with SPHEREx relevance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants