Add online checks to pre interview checks.#8444
Open
KyleMacPherson wants to merge 9 commits intomainfrom
Open
Conversation
KyleMacPherson
force-pushed
the
online-checks
branch
from
8fe2911 to
04017a5
Compare
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
force-pushed
the
online-checks
branch
from
04017a5 to
95d4ba0
Compare
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
force-pushed
the
online-checks
branch
from
390664e to
9aa9ab0
Compare
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
|
Review app deployed to https://teaching-vacancies-review-pr-8444.test.teacherservices.cloud on AKS |
KyleMacPherson
force-pushed
the
online-checks
branch
from
d34d23b to
10be9a3
Compare
starswan
reviewed
Jan 28, 2026
Comment on lines
17
to
19
| = f.govuk_radio_buttons_fieldset :online_checks, legend: { text: t(".question"), size: "m" } do | ||
| = f.govuk_radio_button :online_checks, :yes, label: { text: t(".yes") } | ||
| = f.govuk_radio_button :online_checks, :no, label: { text: t(".no") } |
Contributor
There was a problem hiding this comment.
There is a standard location for these which we are now doing a lot of. Might be worth using it? (online_checks_options with values yes, no and no_doing).
starswan
reviewed
Jan 28, 2026
| before_action :set_job_application | ||
|
|
||
| def edit | ||
| @notes_form = Publishers::JobApplication::NotesForm.new |
Contributor
There was a problem hiding this comment.
I have removed notes_form in a notes_refactor Pr - might be worth re-basing on that? Turns out that was a bit faulty - correct way to make a note is @job_application.notes.build so that note has association back to job_applicaiton
starswan
reviewed
Jan 28, 2026
| = f.govuk_submit t(".save_and_update") | ||
|
|
||
| .govuk-grid-column-one-third | ||
| = render PublisherNotesOnJobApplicationComponent.new(job_application: @job_application, vacancy: @vacancy, notes_form: @notes_form, |
Contributor
There was a problem hiding this comment.
I have changed this so we use a method rather than instantiating the class. There is a notes refactor branch, I will put those changes into that branch so that you can use them
starswan
reviewed
Jan 28, 2026
| expect(publisher_ats_pre_interview_checks_page).to be_displayed | ||
| # This now includes the self disclosure | ||
| expect(publisher_ats_pre_interview_checks_page.reference_links.count).to eq(3) | ||
| expect(publisher_ats_pre_interview_checks_page.reference_links.count).to eq(4) |
Contributor
There was a problem hiding this comment.
might be good to add a better comment explaining the count - my original is a bit lacking :-)
starswan
approved these changes
Jan 28, 2026
KyleMacPherson
force-pushed
the
online-checks
branch
from
10be9a3 to
f4ebf5c
Compare
KyleMacPherson
force-pushed
the
online-checks
branch
from
f218598 to
bd411e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/b6NtBOsO/2391-add-online-checks-to-pre-interview-checks-tab
Changes in this PR:
This PR adds online checks to the pre-interview checks and allows hiring staff to record whether or not they have performed online checks on the applicant.
Screenshots of UI changes:
Before
After
Checklists:
Data & Schema Changes
If this PR modifies data structures or validations, check the following:
If any of the above options has changed then the author must check/resolve all of the following...
Integration Impact
Does this change affect any of these integrations?
User Experience & Data Integrity
Could this change impact: