Skip to content

chore: bump minimum support Go version to 1.25#4403

Merged
darccio merged 8 commits intomainfrom
kakkoyun/bump_go_126
Feb 12, 2026
Merged

chore: bump minimum support Go version to 1.25#4403
darccio merged 8 commits intomainfrom
kakkoyun/bump_go_126

Conversation

@kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Feb 11, 2026

  • chore: bump go directive to 1.25.0 in all modules
  • feat(ci): drop Go 1.24, support Go 1.25/1.26
  • feat(ci): upgrade golangci-lint

xref: DataDog/system-tests#6277

What does this PR do?

Motivation

A new Go version has been released https://go.dev/blog/go1.26 and we bump the minimum supported version.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Propagate go 1.25.0 to root go.mod, go.work, _tools/go.mod,
and all submodule go.mod files via make fix-modules.

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 11, 2026
@kakkoyun kakkoyun force-pushed the kakkoyun/bump_go_126 branch from b56156e to 9ddbe93 Compare February 11, 2026 14:39
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.52%. Comparing base (da2b212) to head (3411755).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
internal/synctest/synctest.go 0.00% <ø> (ø)

... and 435 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Remove GOEXPERIMENT=synctest from all CI scripts and workflows
- Delete internal/synctest/synctest_go124.go fallback
- Remove go1.25 build constraint from internal/synctest/synctest.go
- Update GitHub Actions version matrices to 1.25/1.26
- Update GitLab macrobenchmarks to stable=1.26.0, oldstable=1.25.0
- Update Dockerfiles from golang:1.24 to golang:1.25
- Update Makefile checkmake comment

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@kakkoyun kakkoyun force-pushed the kakkoyun/bump_go_126 branch from 9ddbe93 to 1e5b2db Compare February 11, 2026 15:07
@kakkoyun kakkoyun changed the title chore: Bump minimum support Go version to 1.25 chore: bump minimum support Go version to 1.25 Feb 11, 2026
@kakkoyun kakkoyun marked this pull request as ready for review February 12, 2026 12:16
@kakkoyun kakkoyun requested review from a team as code owners February 12, 2026 12:16
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kakkoyun
Copy link
Member Author

68747470733a2f2f6d65646961312e74656e6f722e636f6d2f6d2f746f4c466a786c5f367a6f41414141432f70726573732d7468652d627574746f6e2d616d6572696361732d676f742d74616c656e742e676966

We need to fix more things 😭

Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAAC


- uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
with:
go-version: stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not the default? (I don't mind having it be explicit anyway)

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@kakkoyun kakkoyun force-pushed the kakkoyun/bump_go_126 branch from 18bde0b to efbc5c2 Compare February 12, 2026 13:26
@kakkoyun kakkoyun marked this pull request as draft February 12, 2026 16:18
Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@kakkoyun
Copy link
Member Author

@darccio WDYT? 9bea83f

@darccio
Copy link
Member

darccio commented Feb 12, 2026

@kakkoyun LGTM!

Signed-off-by: Kemal Akkoyun <kemal.akkoyun@datadoghq.com>
@kakkoyun kakkoyun force-pushed the kakkoyun/bump_go_126 branch from e5ab194 to 44325d0 Compare February 12, 2026 16:58
kakkoyun and others added 2 commits February 12, 2026 18:24
- Update BASE_CI_IMAGE to new pipeline build with Go >= 1.25
- Add GOTOOLCHAIN=auto to benchmark jobs as resilience measure
- Prevents benchmark failures when image Go version < go.work requirement
@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2026

Benchmarks

Benchmark execution time: 2026-02-12 18:32:25

Comparing candidate commit 3411755 in PR branch kakkoyun/bump_go_126 with baseline commit da2b212 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 156 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@darccio darccio marked this pull request as ready for review February 12, 2026 18:35
@darccio darccio requested a review from a team as a code owner February 12, 2026 18:35
@darccio darccio merged commit 7196cbb into main Feb 12, 2026
208 checks passed
@darccio darccio deleted the kakkoyun/bump_go_126 branch February 12, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants