Migrate instrumentations to Context API #9358

PerfectSlayer · 2025-08-13T07:39:31Z

What Does This Do

Migrate HttpServerDecorator.onRequest() to the Context API.

In particular, get rid of the duplicate version using AgentSpan.Extracted instead.
This lead to overridden decorators no longer being called when moved to the Context based version -- unclear how tests did not catch it.

Motivation

Move instrumentation API to the Context API to decouple products and move toward better performance.

Additional Notes

Follow up PR of #9211

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: LANGPLAT-680

datadog-official · 2025-08-13T08:12:28Z

Code coverage: total 57.29%, base diff -0.05%, patch 80.77% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 9f10e63 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-13T08:23:28Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context
git_commit_date	1755498358	1755162649
git_commit_sha	`a11444c`	`9f10e63`
release_version	1.53.0-SNAPSHOT~a11444c5f6	1.53.0-SNAPSHOT~9f10e63c77

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755500085	1755500085
ci_job_id	1083673996	1083673996
ci_pipeline_id	73917154	73917154
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-0jg28c71 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-0jg28c71 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~9f10e63c77, baseline=1.53.0-SNAPSHOT~a11444c5f6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049834
Total [baseline] (10.729 s) : 0, 10728538
Agent [candidate] (1.047 s) : 0, 1047346
Total [candidate] (10.685 s) : 0, 10684666
section appsec
Agent [baseline] (1.225 s) : 0, 1224884
Total [baseline] (10.841 s) : 0, 10840536
Agent [candidate] (1.225 s) : 0, 1224574
Total [candidate] (10.719 s) : 0, 10719216
section iast
Agent [baseline] (1.173 s) : 0, 1173496
Total [baseline] (10.86 s) : 0, 10860230
Agent [candidate] (1.173 s) : 0, 1172633
Total [candidate] (10.851 s) : 0, 10850563
section profiling
Agent [baseline] (1.199 s) : 0, 1198953
Total [baseline] (10.865 s) : 0, 10864777
Agent [candidate] (1.197 s) : 0, 1197334
Total [candidate] (10.824 s) : 0, 10823841

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	appsec	1.225 s	175.05 ms (16.7%)
Agent	iast	1.173 s	123.662 ms (11.8%)
Agent	profiling	1.199 s	149.119 ms (14.2%)
Total	tracing	10.729 s	-
Total	appsec	10.841 s	111.997 ms (1.0%)
Total	iast	10.86 s	131.691 ms (1.2%)
Total	profiling	10.865 s	136.238 ms (1.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	appsec	1.225 s	177.228 ms (16.9%)
Agent	iast	1.173 s	125.287 ms (12.0%)
Agent	profiling	1.197 s	149.988 ms (14.3%)
Total	tracing	10.685 s	-
Total	appsec	10.719 s	34.55 ms (0.3%)
Total	iast	10.851 s	165.897 ms (1.6%)
Total	profiling	10.824 s	139.174 ms (1.3%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~9f10e63c77, baseline=1.53.0-SNAPSHOT~a11444c5f6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (733.935 ms) : 0, 733935
BytebuddyAgent [candidate] (732.738 ms) : 0, 732738
GlobalTracer [baseline] (242.235 ms) : 0, 242235
GlobalTracer [candidate] (242.08 ms) : 0, 242080
AppSec [baseline] (30.263 ms) : 0, 30263
AppSec [candidate] (30.08 ms) : 0, 30080
Debugger [baseline] (6.021 ms) : 0, 6021
Debugger [candidate] (6.007 ms) : 0, 6007
Remote Config [baseline] (646.56 µs) : 0, 647
Remote Config [candidate] (648.888 µs) : 0, 649
Telemetry [baseline] (14.251 ms) : 0, 14251
Telemetry [candidate] (13.358 ms) : 0, 13358
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (756.492 ms) : 0, 756492
BytebuddyAgent [candidate] (757.067 ms) : 0, 757067
GlobalTracer [baseline] (235.71 ms) : 0, 235710
GlobalTracer [candidate] (235.69 ms) : 0, 235690
IAST [baseline] (23.723 ms) : 0, 23723
IAST [candidate] (23.701 ms) : 0, 23701
AppSec [baseline] (168.514 ms) : 0, 168514
AppSec [candidate] (167.207 ms) : 0, 167207
Debugger [baseline] (8.109 ms) : 0, 8109
Debugger [candidate] (8.576 ms) : 0, 8576
Remote Config [baseline] (620.598 µs) : 0, 621
Remote Config [candidate] (613.099 µs) : 0, 613
Telemetry [baseline] (9.217 ms) : 0, 9217
Telemetry [candidate] (9.123 ms) : 0, 9123
section iast
crashtracking [baseline] (1.415 ms) : 0, 1415
crashtracking [candidate] (1.42 ms) : 0, 1420
BytebuddyAgent [baseline] (847.912 ms) : 0, 847912
BytebuddyAgent [candidate] (847.405 ms) : 0, 847405
GlobalTracer [baseline] (232.339 ms) : 0, 232339
GlobalTracer [candidate] (231.831 ms) : 0, 231831
IAST [baseline] (28.206 ms) : 0, 28206
IAST [candidate] (29.43 ms) : 0, 29430
AppSec [baseline] (27.356 ms) : 0, 27356
AppSec [candidate] (27.178 ms) : 0, 27178
Debugger [baseline] (6.485 ms) : 0, 6485
Debugger [candidate] (5.693 ms) : 0, 5693
Remote Config [baseline] (564.596 µs) : 0, 565
Remote Config [candidate] (570.304 µs) : 0, 570
Telemetry [baseline] (8.227 ms) : 0, 8227
Telemetry [candidate] (8.261 ms) : 0, 8261
section profiling
crashtracking [baseline] (1.409 ms) : 0, 1409
crashtracking [candidate] (1.412 ms) : 0, 1412
BytebuddyAgent [baseline] (763.639 ms) : 0, 763639
BytebuddyAgent [candidate] (763.378 ms) : 0, 763378
GlobalTracer [baseline] (222.502 ms) : 0, 222502
GlobalTracer [candidate] (222.531 ms) : 0, 222531
AppSec [baseline] (30.21 ms) : 0, 30210
AppSec [candidate] (30.05 ms) : 0, 30050
Debugger [baseline] (6.246 ms) : 0, 6246
Debugger [candidate] (6.338 ms) : 0, 6338
Remote Config [baseline] (686.551 µs) : 0, 687
Remote Config [candidate] (670.725 µs) : 0, 671
Telemetry [baseline] (16.279 ms) : 0, 16279
Telemetry [candidate] (16.037 ms) : 0, 16037
ProfilingAgent [baseline] (108.407 ms) : 0, 108407
ProfilingAgent [candidate] (107.326 ms) : 0, 107326
Profiling [baseline] (109.042 ms) : 0, 109042
Profiling [candidate] (108.002 ms) : 0, 108002

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~9f10e63c77, baseline=1.53.0-SNAPSHOT~a11444c5f6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042357
Total [baseline] (8.548 s) : 0, 8547706
Agent [candidate] (1.048 s) : 0, 1048389
Total [candidate] (8.567 s) : 0, 8566677
section iast
Agent [baseline] (1.173 s) : 0, 1172671
Total [baseline] (9.263 s) : 0, 9262941
Agent [candidate] (1.184 s) : 0, 1183638
Total [candidate] (9.343 s) : 0, 9343375

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	iast	1.173 s	130.314 ms (12.5%)
Total	tracing	8.548 s	-
Total	iast	9.263 s	715.235 ms (8.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.184 s	135.249 ms (12.9%)
Total	tracing	8.567 s	-
Total	iast	9.343 s	776.698 ms (9.1%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~9f10e63c77, baseline=1.53.0-SNAPSHOT~a11444c5f6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (729.391 ms) : 0, 729391
BytebuddyAgent [candidate] (734.64 ms) : 0, 734640
GlobalTracer [baseline] (240.838 ms) : 0, 240838
GlobalTracer [candidate] (242.231 ms) : 0, 242231
AppSec [baseline] (29.951 ms) : 0, 29951
AppSec [candidate] (30.345 ms) : 0, 30345
Debugger [baseline] (5.995 ms) : 0, 5995
Debugger [candidate] (6.04 ms) : 0, 6040
Remote Config [baseline] (643.664 µs) : 0, 644
Remote Config [candidate] (650.536 µs) : 0, 651
Telemetry [baseline] (13.275 ms) : 0, 13275
Telemetry [candidate] (12.018 ms) : 0, 12018
section iast
crashtracking [baseline] (1.416 ms) : 0, 1416
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (846.952 ms) : 0, 846952
BytebuddyAgent [candidate] (855.173 ms) : 0, 855173
GlobalTracer [baseline] (231.894 ms) : 0, 231894
GlobalTracer [candidate] (233.19 ms) : 0, 233190
IAST [baseline] (27.926 ms) : 0, 27926
IAST [candidate] (30.249 ms) : 0, 30249
AppSec [baseline] (27.409 ms) : 0, 27409
AppSec [candidate] (27.684 ms) : 0, 27684
Debugger [baseline] (7.489 ms) : 0, 7489
Debugger [candidate] (5.793 ms) : 0, 5793
Remote Config [baseline] (567.555 µs) : 0, 568
Remote Config [candidate] (590.892 µs) : 0, 591
Telemetry [baseline] (8.173 ms) : 0, 8173
Telemetry [candidate] (8.428 ms) : 0, 8428

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context
git_commit_date	1755498358	1755162649
git_commit_sha	`a11444c`	`9f10e63`
release_version	1.53.0-SNAPSHOT~a11444c5f6	1.53.0-SNAPSHOT~9f10e63c77

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755499772	1755499772
ci_job_id	1083673997	1083673997
ci_pipeline_id	73917154	73917154
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-15uc9mjh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-15uc9mjh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	better [-501.580µs; -255.405µs] or [-6.265%; -3.190%]	unstable [-39.894op/s; +96.707op/s] or [-6.895%; +16.713%]	7.627ms	607.031op/s	8.006ms	578.625op/s
scenario:load:insecure-bank:profiling:high_load	better [-714.709µs; -406.159µs] or [-7.757%; -4.408%]	unstable [-29.559op/s; +94.247op/s] or [-5.868%; +18.710%]	8.654ms	536.062op/s	9.214ms	503.719op/s
scenario:load:petclinic:iast:high_load	better [-2.260ms; -1.441ms] or [-4.873%; -3.107%]	unstable [-2.865op/s; +11.215op/s] or [-2.840%; +11.118%]	44.538ms	105.050op/s	46.389ms	100.875op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9f10e63c77, baseline=1.53.0-SNAPSHOT~a11444c5f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.669 ms) : 37360, 37979
.   : milestone, 37669,
appsec (46.438 ms) : 46031, 46845
.   : milestone, 46438,
code_origins (45.125 ms) : 44726, 45524
.   : milestone, 45125,
iast (46.389 ms) : 45999, 46778
.   : milestone, 46389,
profiling (48.054 ms) : 47604, 48504
.   : milestone, 48054,
tracing (45.196 ms) : 44821, 45571
.   : milestone, 45196,
section candidate
no_agent (38.361 ms) : 38056, 38667
.   : milestone, 38361,
appsec (46.738 ms) : 46329, 47148
.   : milestone, 46738,
code_origins (46.419 ms) : 46019, 46818
.   : milestone, 46419,
iast (44.538 ms) : 44166, 44909
.   : milestone, 44538,
profiling (47.171 ms) : 46714, 47628
.   : milestone, 47171,
tracing (45.338 ms) : 44947, 45728
.   : milestone, 45338,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.669 ms [37.36 ms, 37.979 ms]	-
appsec	46.438 ms [46.031 ms, 46.845 ms]	8.768 ms (23.3%)
code_origins	45.125 ms [44.726 ms, 45.524 ms]	7.456 ms (19.8%)
iast	46.389 ms [45.999 ms, 46.778 ms]	8.719 ms (23.1%)
profiling	48.054 ms [47.604 ms, 48.504 ms]	10.385 ms (27.6%)
tracing	45.196 ms [44.821 ms, 45.571 ms]	7.527 ms (20.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.361 ms [38.056 ms, 38.667 ms]	-
appsec	46.738 ms [46.329 ms, 47.148 ms]	8.377 ms (21.8%)
code_origins	46.419 ms [46.019 ms, 46.818 ms]	8.057 ms (21.0%)
iast	44.538 ms [44.166 ms, 44.909 ms]	6.176 ms (16.1%)
profiling	47.171 ms [46.714 ms, 47.628 ms]	8.81 ms (23.0%)
tracing	45.338 ms [44.947 ms, 45.728 ms]	6.976 ms (18.2%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9f10e63c77, baseline=1.53.0-SNAPSHOT~a11444c5f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.37 ms) : 4315, 4425
.   : milestone, 4370,
iast (9.392 ms) : 9238, 9546
.   : milestone, 9392,
iast_FULL (13.606 ms) : 13340, 13872
.   : milestone, 13606,
iast_GLOBAL (10.22 ms) : 10039, 10400
.   : milestone, 10220,
profiling (9.214 ms) : 9063, 9365
.   : milestone, 9214,
tracing (8.006 ms) : 7893, 8119
.   : milestone, 8006,
section candidate
no_agent (4.442 ms) : 4392, 4493
.   : milestone, 4442,
iast (9.263 ms) : 9107, 9418
.   : milestone, 9263,
iast_FULL (13.804 ms) : 13530, 14077
.   : milestone, 13804,
iast_GLOBAL (10.358 ms) : 10177, 10539
.   : milestone, 10358,
profiling (8.654 ms) : 8518, 8789
.   : milestone, 8654,
tracing (7.627 ms) : 7512, 7743
.   : milestone, 7627,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.37 ms [4.315 ms, 4.425 ms]	-
iast	9.392 ms [9.238 ms, 9.546 ms]	5.022 ms (114.9%)
iast_FULL	13.606 ms [13.34 ms, 13.872 ms]	9.235 ms (211.3%)
iast_GLOBAL	10.22 ms [10.039 ms, 10.4 ms]	5.849 ms (133.8%)
profiling	9.214 ms [9.063 ms, 9.365 ms]	4.844 ms (110.8%)
tracing	8.006 ms [7.893 ms, 8.119 ms]	3.635 ms (83.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.442 ms [4.392 ms, 4.493 ms]	-
iast	9.263 ms [9.107 ms, 9.418 ms]	4.82 ms (108.5%)
iast_FULL	13.804 ms [13.53 ms, 14.077 ms]	9.361 ms (210.7%)
iast_GLOBAL	10.358 ms [10.177 ms, 10.539 ms]	5.915 ms (133.2%)
profiling	8.654 ms [8.518 ms, 8.789 ms]	4.211 ms (94.8%)
tracing	7.627 ms [7.512 ms, 7.743 ms]	3.185 ms (71.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/context
git_commit_date	1755498358	1755162649
git_commit_sha	`a11444c`	`9f10e63`
release_version	1.53.0-SNAPSHOT~a11444c5f6	1.53.0-SNAPSHOT~9f10e63c77

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755500250	1755500250
ci_job_id	1083673998	1083673998
ci_pipeline_id	73917154	73917154
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-hf1u53v7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-hf1u53v7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9f10e63c77, baseline=1.53.0-SNAPSHOT~a11444c5f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (3.671 ms) : 3453, 3889
.   : milestone, 3671,
iast (2.204 ms) : 2141, 2268
.   : milestone, 2204,
iast_GLOBAL (2.242 ms) : 2179, 2305
.   : milestone, 2242,
profiling (2.04 ms) : 1989, 2090
.   : milestone, 2040,
tracing (2.016 ms) : 1967, 2064
.   : milestone, 2016,
section candidate
no_agent (1.48 ms) : 1468, 1492
.   : milestone, 1480,
appsec (3.679 ms) : 3462, 3897
.   : milestone, 3679,
iast (2.197 ms) : 2133, 2260
.   : milestone, 2197,
iast_GLOBAL (2.246 ms) : 2183, 2309
.   : milestone, 2246,
profiling (2.056 ms) : 2005, 2107
.   : milestone, 2056,
tracing (2.024 ms) : 1975, 2073
.   : milestone, 2024,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.465 ms, 1.488 ms]	-
appsec	3.671 ms [3.453 ms, 3.889 ms]	2.194 ms (148.6%)
iast	2.204 ms [2.141 ms, 2.268 ms]	727.637 µs (49.3%)
iast_GLOBAL	2.242 ms [2.179 ms, 2.305 ms]	764.957 µs (51.8%)
profiling	2.04 ms [1.989 ms, 2.09 ms]	563.122 µs (38.1%)
tracing	2.016 ms [1.967 ms, 2.064 ms]	539.122 µs (36.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.48 ms [1.468 ms, 1.492 ms]	-
appsec	3.679 ms [3.462 ms, 3.897 ms]	2.2 ms (148.6%)
iast	2.197 ms [2.133 ms, 2.26 ms]	716.638 µs (48.4%)
iast_GLOBAL	2.246 ms [2.183 ms, 2.309 ms]	766.246 µs (51.8%)
profiling	2.056 ms [2.005 ms, 2.107 ms]	576.104 µs (38.9%)
tracing	2.024 ms [1.975 ms, 2.073 ms]	544.562 µs (36.8%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9f10e63c77, baseline=1.53.0-SNAPSHOT~a11444c5f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.928 s) : 14928000, 14928000
.   : milestone, 14928000,
appsec (14.835 s) : 14835000, 14835000
.   : milestone, 14835000,
iast (18.431 s) : 18431000, 18431000
.   : milestone, 18431000,
iast_GLOBAL (18.235 s) : 18235000, 18235000
.   : milestone, 18235000,
profiling (15.78 s) : 15780000, 15780000
.   : milestone, 15780000,
tracing (14.996 s) : 14996000, 14996000
.   : milestone, 14996000,
section candidate
no_agent (15.356 s) : 15356000, 15356000
.   : milestone, 15356000,
appsec (14.825 s) : 14825000, 14825000
.   : milestone, 14825000,
iast (18.749 s) : 18749000, 18749000
.   : milestone, 18749000,
iast_GLOBAL (18.083 s) : 18083000, 18083000
.   : milestone, 18083000,
profiling (15.381 s) : 15381000, 15381000
.   : milestone, 15381000,
tracing (15.225 s) : 15225000, 15225000
.   : milestone, 15225000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.928 s [14.928 s, 14.928 s]	-
appsec	14.835 s [14.835 s, 14.835 s]	-93.0 ms (-0.6%)
iast	18.431 s [18.431 s, 18.431 s]	3.503 s (23.5%)
iast_GLOBAL	18.235 s [18.235 s, 18.235 s]	3.307 s (22.2%)
profiling	15.78 s [15.78 s, 15.78 s]	852.0 ms (5.7%)
tracing	14.996 s [14.996 s, 14.996 s]	68.0 ms (0.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.356 s [15.356 s, 15.356 s]	-
appsec	14.825 s [14.825 s, 14.825 s]	-531.0 ms (-3.5%)
iast	18.749 s [18.749 s, 18.749 s]	3.393 s (22.1%)
iast_GLOBAL	18.083 s [18.083 s, 18.083 s]	2.727 s (17.8%)
profiling	15.381 s [15.381 s, 15.381 s]	25.0 ms (0.2%)
tracing	15.225 s [15.225 s, 15.225 s]	-131.0 ms (-0.9%)

smola

I did an overall review, particularly focusing on the AppSec instrumentations, looks good to me.

smola · 2025-08-13T09:08:17Z

...umentation/axway-api/src/main/java/datadog/trace/instrumentation/axway/HTTPPluginAdvice.java

 import net.bytebuddy.asm.Advice;

 public class HTTPPluginAdvice {

  @Advice.OnMethodEnter(suppress = Throwable.class)
  public static AgentScope onEnter(@Advice.Argument(value = 2) final Object serverTransaction) {
-    final AgentSpan span = startSpan(DECORATE.spanName()).setMeasured(true);
+    final AgentSpan span = startSpan("axway-api", DECORATE.spanName()).setMeasured(true);


I didn't verify axway-api is the correct integration name just based on the diff, but worth a double check.

Yes it is:

dd-trace-java/dd-java-agent/instrumentation/axway-api/src/main/java/datadog/trace/instrumentation/axway/AxwayHTTPPluginInstrumentation.java

Line 18 in e8df8a0

super("axway-api");

Not sure why I fixed this call in particular 🤷 Found a warning while reading the code and can't help myself 😅 But it's more to the IDM team to fix it.

...rtx-web-3.4/src/main/java/datadog/trace/instrumentation/vertx_3_4/server/VertxDecorator.java

feat(bootstrap): Migrate Spray instrumentation to Context API

dc9d144

PerfectSlayer added the tag: do not merge Do not merge changes label Aug 13, 2025

PerfectSlayer added 2 commits August 13, 2025 09:47

feat(bootstrap): Migrate Tomcat instrumentation to Context API

a5d200d

feat(bootstrap): Migrate Liberty instrumentations to Context API

9994ab4

feat(bootstrap): Migrate instrumentations to Context API

c82297c

PerfectSlayer added type: refactoring comp: context propagation Trace context propagation and removed tag: do not merge Do not merge changes labels Aug 13, 2025

PerfectSlayer marked this pull request as ready for review August 13, 2025 09:00

PerfectSlayer requested review from a team as code owners August 13, 2025 09:00

PerfectSlayer requested a review from smola August 13, 2025 09:00

smola requested review from a team, jandro996, ygree and smola and removed request for smola and a team August 13, 2025 09:00

smola approved these changes Aug 13, 2025

View reviewed changes

PerfectSlayer mentioned this pull request Aug 13, 2025

Improve Instrumenter API to use Context instead of Span #9211

Merged

PerfectSlayer added 2 commits August 13, 2025 12:24

fix(bootstrap): Fix unexpected call to IG callback

a565097

feat(play): Simplify testing

f3a982f

AlexeyKuznetsov-DD approved these changes Aug 13, 2025

View reviewed changes

sarahchen6 reviewed Aug 13, 2025

View reviewed changes

...rtx-web-3.4/src/main/java/datadog/trace/instrumentation/vertx_3_4/server/VertxDecorator.java Outdated Show resolved Hide resolved

sarahchen6 approved these changes Aug 13, 2025

View reviewed changes

PerfectSlayer mentioned this pull request Aug 14, 2025

[Java] Fix exception replay snapshots DataDog/system-tests#5066

Merged

6 tasks

fix(bootstrap): Fix import

9f10e63

PerfectSlayer requested a review from a team as a code owner August 14, 2025 09:11

PerfectSlayer requested review from bric3 and removed request for a team August 14, 2025 09:11

mhlidd mentioned this pull request Aug 14, 2025

[Java] Disabling Debugger Tests DataDog/system-tests#5072

Merged

6 tasks

PerfectSlayer force-pushed the bbujon/context branch from 364cab5 to 9f10e63 Compare August 18, 2025 06:25

PerfectSlayer mentioned this pull request Aug 18, 2025

[Java] Restoring Debugger Tests DataDog/system-tests#5082

Open

6 tasks

PerfectSlayer enabled auto-merge (squash) August 18, 2025 06:32

PerfectSlayer merged commit 9f546b9 into master Aug 18, 2025
501 checks passed

PerfectSlayer deleted the bbujon/context branch August 18, 2025 07:15

github-actions bot added this to the 1.53.0 milestone Aug 18, 2025

This was referenced Aug 19, 2025

Migrate instrumentations to Context API #9378

Merged

Migrate instrumentations to Context API #9384

Merged

Refactor Severless Gateway Inferred Span #9388

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate instrumentations to Context API #9358

Migrate instrumentations to Context API #9358

Uh oh!

PerfectSlayer commented Aug 13, 2025 •

edited by jira bot

Loading

Uh oh!

datadog-official bot commented Aug 13, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

Uh oh!

pr-commenter bot commented Aug 13, 2025 •

edited

Loading

Uh oh!

smola left a comment

Uh oh!

smola Aug 13, 2025

Uh oh!

PerfectSlayer Aug 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Migrate instrumentations to Context API #9358

Migrate instrumentations to Context API #9358

Uh oh!

Conversation

PerfectSlayer commented Aug 13, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Aug 13, 2025 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

smola left a comment

Choose a reason for hiding this comment

Uh oh!

smola Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PerfectSlayer commented Aug 13, 2025 •

edited by jira bot

Loading

datadog-official bot commented Aug 13, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

pr-commenter bot commented Aug 13, 2025 •

edited

Loading

PerfectSlayer Aug 13, 2025 •

edited

Loading