Skip to content

Revise model choice for managed LLM samples #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 21, 2025
Merged

Revise model choice for managed LLM samples #378

merged 7 commits into from
May 21, 2025

Conversation

commit111
Copy link
Collaborator

@commit111 commit111 commented May 20, 2025 •
edited by github-actions bot
Loading

related to DefangLabs/defang-docs#234

Samples Checklist

✅ All good!

@commit111 commit111 requested a review from jordanstephens May 20, 2025 20:04
@commit111 commit111 had a problem deploying to deploy-changed-samples May 20, 2025 20:04 — with GitHub Actions Failure
lionello
lionello reviewed May 20, 2025
View reviewed changes
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires @nullfunc 's model-map PR to go in first (and pushed to Docker Hub), no?)

@commit111 commit111 had a problem deploying to deploy-changed-samples May 20, 2025 20:40 — with GitHub Actions Failure
nullfunc
nullfunc reviewed May 20, 2025
View reviewed changes
@commit111 commit111 had a problem deploying to deploy-changed-samples May 20, 2025 21:52 — with GitHub Actions Failure
@commit111 commit111 mentioned this pull request May 20, 2025
Closed
@commit111 commit111 had a problem deploying to deploy-changed-samples May 20, 2025 23:12 — with GitHub Actions Failure
@commit111 commit111 changed the title Add cloud-neutral name for model in managed LLM Revise model naming for managed LLM samples May 20, 2025
@commit111 commit111 changed the title Revise model naming for managed LLM samples Revise model choice for managed LLM samples May 20, 2025
@nullfunc nullfunc self-requested a review May 20, 2025 23:15
@commit111 commit111 had a problem deploying to deploy-changed-samples May 20, 2025 23:25 — with GitHub Actions Failure
jordanstephens
jordanstephens approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@jordanstephens jordanstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still disagree that we should mention aws-specific models in our docs or our samples (since our goal is to be cloud-neutral), but I won't hold this up anymore if I'm the only one that feels this way

@nullfunc nullfunc mentioned this pull request May 20, 2025
Closed
@commit111
Copy link
Collaborator Author

Thinking of using MODEL=default. Will wait for Eric's PR to be up before I push my committed changes to this branch

@commit111 commit111 temporarily deployed to deploy-changed-samples May 21, 2025 00:05 — with GitHub Actions Inactive
@commit111 commit111 mentioned this pull request May 21, 2025
Closed
@commit111 commit111 merged commit 765fe5c into main May 21, 2025
6 checks passed
@commit111 commit111 mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionello lionello lionello left review comments

@jordanstephens jordanstephens jordanstephens approved these changes

@nullfunc nullfunc nullfunc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@commit111 @lionello @jordanstephens @nullfunc